From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11811 invoked by alias); 6 Oct 2006 23:39:11 -0000 Received: (qmail 11802 invoked by uid 22791); 6 Oct 2006 23:39:11 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.palmsource.com (HELO mx2.palmsource.com) (12.7.175.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Oct 2006 23:39:09 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost.domain.tld (Postfix) with ESMTP id AD1BB26D18; Fri, 6 Oct 2006 16:39:07 -0700 (PDT) Received: from mx2.palmsource.com ([127.0.0.1]) by localhost (mx2.palmsource.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 31561-02-67; Fri, 6 Oct 2006 16:39:06 -0700 (PDT) Received: from ussunex01.palmsource.com (unknown [192.168.101.9]) by mx2.palmsource.com (Postfix) with ESMTP id D7FC726D15; Fri, 6 Oct 2006 16:39:06 -0700 (PDT) Received: from 192.168.92.75 ([192.168.92.75]) by ussunex01.palmsource.com ([192.168.101.9]) via Exchange Front-End Server owa.palmsource.com ([10.0.20.17]) with Microsoft Exchange Server HTTP-DAV ; Fri, 6 Oct 2006 23:39:05 +0000 Received: from svmsnyderlnx by owa.palmsource.com; 06 Oct 2006 16:39:04 -0700 Subject: Re: [patch] realloc bug in add_symbol_file_command From: Michael Snyder To: Jean-Marc Saffroy Cc: gdb-patches@sourceware.org In-Reply-To: References: <1160170029.19232.0.camel@localhost.localdomain> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 06 Oct 2006 23:39:00 -0000 Message-Id: <1160177944.14535.10.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00072.txt.bz2 On Fri, 2006-10-06 at 23:57 +0200, Jean-Marc Saffroy wrote: > On Fri, 6 Oct 2006, Michael Snyder wrote: > > > On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote: > >> Hello, > >> > >> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel > >> modules have many sections... :) The patch below lets me load many modules > >> now. > > > > Just to be safe, might you want to use >=? > > Do you fear the processor would skip a number when incrementing the > variable indexing the section array? ;-) Yes. I'm just paranoid that way. ;-) > Given the current code, it should not be necessary in any way, but feel > free to change the patch as you please. It was just a suggestion, not a demand. Anyway, I was going to approve your change, but I see that it's already in. Andreas Schwab anticipated you on August 24. Great minds think alike. ;-)