From: Michael Snyder <Michael.Snyder@palmsource.com>
To: Jean-Marc Saffroy <saffroy@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] realloc bug in add_symbol_file_command
Date: Fri, 06 Oct 2006 23:39:00 -0000 [thread overview]
Message-ID: <1160177944.14535.10.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0610062346030.9250@erda.mds>
On Fri, 2006-10-06 at 23:57 +0200, Jean-Marc Saffroy wrote:
> On Fri, 6 Oct 2006, Michael Snyder wrote:
>
> > On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote:
> >> Hello,
> >>
> >> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel
> >> modules have many sections... :) The patch below lets me load many modules
> >> now.
> >
> > Just to be safe, might you want to use >=?
>
> Do you fear the processor would skip a number when incrementing the
> variable indexing the section array? ;-)
Yes. I'm just paranoid that way. ;-)
> Given the current code, it should not be necessary in any way, but feel
> free to change the patch as you please.
It was just a suggestion, not a demand.
Anyway, I was going to approve your change, but I see that it's
already in. Andreas Schwab anticipated you on August 24.
Great minds think alike. ;-)
prev parent reply other threads:[~2006-10-06 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 14:18 Jean-Marc Saffroy
2006-10-06 21:27 ` Michael Snyder
2006-10-06 21:59 ` Jean-Marc Saffroy
2006-10-06 23:39 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160177944.14535.10.camel@localhost.localdomain \
--to=michael.snyder@palmsource.com \
--cc=gdb-patches@sourceware.org \
--cc=saffroy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox