From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26192 invoked by alias); 6 Oct 2006 21:59:37 -0000 Received: (qmail 26183 invoked by uid 22791); 6 Oct 2006 21:59:37 -0000 X-Spam-Check-By: sourceware.org Received: from pas38-1-82-67-71-117.fbx.proxad.net (HELO siegfried.gbfo.org) (82.67.71.117) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Oct 2006 21:59:33 +0000 Received: from erda.mds (localhost [127.0.0.1]) by siegfried.gbfo.org (8.13.6/8.13.6) with ESMTP id k96LvemU028426; Fri, 6 Oct 2006 23:57:40 +0200 Received: from localhost (saffroy@localhost) by erda.mds (8.13.6/8.13.6/Submit) with ESMTP id k96LvdqR028423; Fri, 6 Oct 2006 23:57:40 +0200 Date: Fri, 06 Oct 2006 21:59:00 -0000 From: Jean-Marc Saffroy To: Michael Snyder cc: gdb-patches@sourceware.org Subject: Re: [patch] realloc bug in add_symbol_file_command In-Reply-To: <1160170029.19232.0.camel@localhost.localdomain> Message-ID: References: <1160170029.19232.0.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00071.txt.bz2 On Fri, 6 Oct 2006, Michael Snyder wrote: > On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote: >> Hello, >> >> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel >> modules have many sections... :) The patch below lets me load many modules >> now. > > Just to be safe, might you want to use >=? Do you fear the processor would skip a number when incrementing the variable indexing the section array? ;-) Given the current code, it should not be necessary in any way, but feel free to change the patch as you please. Cheers, -- saffroy@gmail.com