Re: [PATCH v2 11/11] Add aarch64-windows support

[Hannes Domani <ssbssa@yahoo.de>]

 Am Mittwoch, 21. Januar 2026 um 17:18:43 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
> 
> Hannes> Changes in v2:
> Hannes>  - added new source files to ALLDEPFILES
> Hannes>  - created NEWS entry
> Hannes>  - removed set_gdbarch_auto_wide_charset and set_gdbarch_long_bit calls
> Hannes>    since these are now done in windows-tdep.c
> Hannes>  - added comments to aarch64_windows_breakpoint and
> Hannes>    set_gdbarch_decr_pc_after_break
> Hannes>  - removed unused 32bit code in
> Hannes>    aarch64_windows_nat_target::fetch_one_register()
> Hannes>  - changed stopped_data_address() to stopped_data_addresses() in
> Hannes>    aarch64_windows_nat_target, and updated stopped_by_watchpoint()
> Hannes>  - initialize windows_process inside INIT_GDB_FILE(aarch64_windows_nat)
> 
> Thank you.  I have a couple of nits but nothing serious.
> 
> Hannes> +struct aarch64_windows_nat_target final :
> Hannes> +  public aarch64_nat_target<windows_nat_target>
> 
> I guess I'd stick the ":" on the second line, following the operator
> rule (even though it's not really an operator).
> 
> Hannes> +void
> Hannes> +aarch64_windows_nat_target::initialize_windows_arch (bool attaching)
> Hannes> +{
> Hannes> +  memset (&aarch64_windows_process.dr_state, 0,
> Hannes> +      sizeof (aarch64_windows_process.dr_state));
> Hannes> +
> Hannes> +  aarch64_windows_process.mappings  = aarch64_mappings;
> 
> Extra space before the '=' here.
> 
> 
> Ok with these nits fixed.
> Approved-By: Tom Tromey <tom@tromey.com>

I've made these changes, thanks.


Hannes