Re: [PATCH v2 02/11] Simplify windows_nat_target::resume

[Hannes Domani <ssbssa@yahoo.de>]

 Am Montag, 19. Januar 2026 um 14:55:44 MEZ hat Schimpe, Christina <christina.schimpe@intel.com> Folgendes geschrieben:

> > -----Original Message-----
> 
> > From: Hannes Domani <ssbssa@yahoo.de>
> > Sent: Samstag, 17. Januar 2026 14:36
> > To: gdb-patches@sourceware.org
> > Cc: Tom Tromey <tom@tromey.com>
> > Subject: [PATCH v2 02/11] Simplify windows_nat_target::resume
> >
> > Now the thread context is only needed for setting the trace bit, so move the
> > rest out of the with_context lambda.
> >
> > Approved-By: Tom Tromey <tom@tromey.com>
> > ---
> > No changes in v2
> > ---
> >  gdb/windows-nat.c | 15 ++++++---------
> >  1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index
> > a6fd199530c..8ee52768cb1 100644
> > --- a/gdb/windows-nat.c
> > +++ b/gdb/windows-nat.c
> > @@ -1366,18 +1366,15 @@ windows_nat_target::resume (ptid_t ptid, int
> > step, enum gdb_signal sig)
> >
> >    /* Get context for currently selected thread.  */
> >    th = windows_process.thread_rec (inferior_ptid,
> > DONT_INVALIDATE_CONTEXT);
> > -  if (th)
> > +  if (th && step)
> 
> 
> Nit: better to check th != nullptr here explicitly.

Thanks, I've made this change.


Hannes