Re: [PATCH v2 11/11] Add aarch64-windows support

[Eli Zaretskii <eliz@gnu.org>]

> From: Hannes Domani <ssbssa@yahoo.de>
> Date: Sat, 17 Jan 2026 14:54:34 +0100
> 
> This makes most debugging work, except unwinding doesn't always work
> from inside dlls where no debug info is available, because SEH unwinding
> is not implemented.
> 
> The number of available hardware breakpoints is taken from
> ID_AA64DFR0_EL1 (registry key "CP 4028").
> As for hardware watchpoints, even though ARM64_MAX_WATCHPOINTS is 2,
> testing showed that only 1 ever works, so it's fixed to that value.
> ---
> Changes in v2:
>   - added new source files to ALLDEPFILES
>   - created NEWS entry
>   - removed set_gdbarch_auto_wide_charset and set_gdbarch_long_bit calls
>     since these are now done in windows-tdep.c
>   - added comments to aarch64_windows_breakpoint and
>     set_gdbarch_decr_pc_after_break
>   - removed unused 32bit code in
>     aarch64_windows_nat_target::fetch_one_register()
>   - changed stopped_data_address() to stopped_data_addresses() in
>     aarch64_windows_nat_target, and updated stopped_by_watchpoint()
>   - initialize windows_process inside INIT_GDB_FILE(aarch64_windows_nat)
> ---
>  gdb/Makefile.in            |   3 +
>  gdb/NEWS                   |   2 +
>  gdb/aarch64-windows-nat.c  | 346 +++++++++++++++++++++++++++++++++++++
>  gdb/aarch64-windows-tdep.c |  70 ++++++++
>  gdb/coff-pe-read.c         |   6 +-
>  gdb/configure.host         |   3 +
>  gdb/configure.nat          |   4 +
>  gdb/configure.tgt          |   5 +
>  gdb/nat/windows-nat.c      |   5 +
>  gdb/nat/windows-nat.h      |   2 +
>  10 files changed, 444 insertions(+), 2 deletions(-)
>  create mode 100644 gdb/aarch64-windows-nat.c
>  create mode 100644 gdb/aarch64-windows-tdep.c

Thanks, the NEWS part is okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>