RE: [PATCH v2 05/11] Move x86 debug registers and related code into x86-windows-nat.c

["Schimpe, Christina" <christina.schimpe@intel.com>]

> -----Original Message-----
> From: Hannes Domani <ssbssa@yahoo.de>
> Sent: Dienstag, 20. Januar 2026 16:50
> To: gdb-patches@sourceware.org; Schimpe, Christina
> <christina.schimpe@intel.com>; Tom Tromey <tom@tromey.com>
> Subject: Re: [PATCH v2 05/11] Move x86 debug registers and related code
> into x86-windows-nat.c
> 
> Am Montag, 19. Januar 2026 um 13:49:30 MEZ hat Schimpe, Christina
> <christina.schimpe@intel.com> Folgendes geschrieben:
> 
> > > --- a/gdb/x86-windows-nat.c
> > > +++ b/gdb/x86-windows-nat.c
> > > @@ -18,22 +18,213 @@
> > >    along with this program.  If not, see
> > ><http://www.gnu.org/licenses/>.  */
> > >
> > >  #include "windows-nat.h"
> > > +#include "regcache.h"
> > > +#include "gdbarch.h"
> > >
> > >  #include "x86-nat.h"
> > >
> > > +using namespace windows_nat;
> > > +
> > > +/* If we're not using the old Cygwin header file set, define the
> > > +  following which never should have been in the generic Win32 API
> > > +  headers in the first place since they were our own invention...
> > > +*/ #ifndef _GNU_H_WINDOWS_H enum
> > > +  {
> > > +    FLAG_TRACE_BIT = 0x100,
> > > +  };
> > > +#endif
> > > +
> > > +#define DR6_CLEAR_VALUE 0xffff0ff0
> > > +
> > > +#define CHECK(x)    check (x, __FILE__,__LINE__)
> > > +
> > > +static void
> > > +check (BOOL ok, const char *file, int line) {
> >
> > Isn't the exact same function also available in windows-nat.c ?
> > Shouldn't we better share the code?
> 
> You're right, I forgot that I copied that function, I wonder if I should make it a
> (static) windows_nat_target member.

I'd have preferred a free function, or what's the benefit of making it a static member ?

> And should I move the CHECK define to windows-nat.h as well?

I think that would make sense.

Christina
Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928