From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sRtkOdvIc2mzwREAWB0awg (envelope-from ) for ; Fri, 23 Jan 2026 14:15:39 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=DJST72t/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E70D61E0AD; Fri, 23 Jan 2026 14:15:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8902B1E089 for ; Fri, 23 Jan 2026 14:15:39 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1505F4BCA2E3 for ; Fri, 23 Jan 2026 19:15:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1505F4BCA2E3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=DJST72t/ Received: from sonic311-31.consmr.mail.ir2.yahoo.com (sonic311-31.consmr.mail.ir2.yahoo.com [77.238.176.163]) by sourceware.org (Postfix) with ESMTPS id 7367E4BCA418 for ; Fri, 23 Jan 2026 19:14:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7367E4BCA418 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7367E4BCA418 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.176.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769195689; cv=none; b=K8kUjr/Hd0tD5dRK4UCXIuObUmETu//AWbC4rzH2b6luaf69z4Wmarf9a1jQXqCpTQcJqgVcvMZZGaYuqrTpE0n5CDfRfBHihc1UQIJjTTd4N7FNl7pWDnlxLgq7+CQD372mtqEWBCNVFNIOrACygrdtSnuFLdo1kYTenpAoWhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769195689; c=relaxed/simple; bh=li2lE223iHiym0nk+qaruikkWW3pLvBTfzBI81Tsqes=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=pOfabKEKBXza5owvdAdMtDNc8+thhe/659wmTMHp5FLpPhCoJJ3soDsqUFFc3wS9SyOZrG5vkKkT2MaFlfLLflmCMVjfMJ6nPU3Hx72/XnbP2yfPTlZggoNIn/oeihSVlZBCJd5QKpn2OIqUPRlUpZm3FmSkmvF99dy1zjZNd10= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7367E4BCA418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1769195662; bh=li2lE223iHiym0nk+qaruikkWW3pLvBTfzBI81Tsqes=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=DJST72t/G3FZhrISRiHi/65v42M+ZIfNoPfH82R/60/xE1+RxmJ35E+TxipEJV72V74/C8F5Hi4g8Eq1D1q/LJ88K2Ohc1DyHHwEQlCWrDCTy35Kv0QZqdatU2UhFkMzR7HrlVof86fwadR2ooaVSa7BlRPqp/Doh6NNhHnovP2nZFGMMI0eJkzxBB/la3635mtzZReyHyCr81++FCnxmYEbJh49Pp2KyUNPuOxUZbeQ2KCUV/goz8dxPzLaREHH86SnHaTBftOL8VPbbD73Z0TLLa9VxFZzbip3i1mtBO4WMSYlVqjtQLQ0hcFejlN7lIfNVNVmX3ZT5LnWuLgWlw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1769195662; bh=7iXkiHSzjRw/KEegRU1r0HdBe4uTU3bc1i5qb9tKvR6=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=CDoMINMwrPnBOIBFCW7Gy46nXeTBzdyxw3z/Qx8HG11UrpsnLh3z/ZwZY0q25L5b6obl+eZpS1Yx2xRjCUma6KYSQX9WBhCNqHi190H60zY/YT5u7ObFe/w/rW5hFvsLpMCOUANTOiDRuown03D2Fb/CC4a7smmDxIl1j/G0D9Loy41g+RHHcI7nfZmjSbqn+gAWq1sD61Ys7LQHC1zprdZkXu8IPvTfCrMogbLUtIPzGsOWwK8mCMjaFsyDReEKgZq5094o4nxEDAZcgTXaDCBc5Z7E8XVV734aAYC4V8Ucwj9vhUX4vRqmBQo+50zfyvAqdY/45fET31xkSsxxvQ== X-YMail-OSG: wc4b_AMVM1kb1uWw9ppQdKmb6H00YivqkHXlcxdxjJiyPxLAPL4S8NhsC_TB06g D7fPKBqn5DbZ9KQgu76BrvYSG_L3kq84nrf0v5OI5.XrtpQjNxNeWzx_5ESQ.ox_lXo08fuu_bdh dGXffmrQF4bqqOeYGzgbLm9KUCYgh6q8RtZ5_gimw65ZWXjhtJqU4RWCgEtHqlCPuCoPslvwSigd W39LikeqneY2XDvFr3u_f5pi7B7_QFropEMvQMsRchbxRFx7fYU7WrC0btOk0T.0vVM_9rd1zMxz X3cyglrl1XBxOCocjBAK49eCscSfTA7SmwPlTpvpPvCto_YckNFbDBdaB4tlQ_hJRVaYmyPZnMqw qLSZCa3O_x179.gcmjbepuX4rm5RDbAPOQKAbNqr5UVQ.6Pn.jbka4.fV.uccdX9Qicv4ZSDSOvB 9Ek9XxnmQQqzqBwnfrXqkVbhAswsa7OsPip63EjPZbtjlE6I.6c._MnzFuktTlWXCNajTt0emH_J KLh4C5JM49rvpNTzJgHd3eb7lO2P6A5fmPd3CiUlAPq.Q0LVeWiYn.L2aph.HYTKwApvnm.JDXGJ KSTPQokjUchbxy.VM9yB5_rKuLtgzBdoqk_qHD6a6Ca_efnI2IN5ftHmnOI_c72zmbWzAXRcqo5y YFu_djRxu.ZU9ig30tZ5Y_R.acqBQgbUyrDUg7N7gAZV4iwgCyrBah.miAOL5_sI568iOs1w8c_R lz4IptbkKAatgd4wHEGOqO96XnVytdx_R_BIIro.is1vxIVKR4tc5fY4e5riWN6EgttRYbrWRkll CloGVyHYR_OsuXQSJe8qTIlEVO2xJhY2YdflOlxa_wjD4wW05v8Z7Swrt8ByROZ2jPidPJf4P1QJ gQ7OyVbmPvby6LCkzrDaTnKhvsraKimli4eRmwsMyKJRrOo3OXzhYh4J30JMu16gIuOXbMA4tQZO WXOrTT0i792WqxIsHFrkm7Tfqj9hmQgpRw3GesuWIeLJHVUk8dYqyALHXT6rDDDy2qaiyh06I3Ip dlFlIMwwxbxar9uwaeMo78q0RDaBhYtEvbiuQQzmz1UDUK2OTthhcX5fwjezAtagORAUKuupKnYc YOlUTSL77_j0Kb.TJVsJjLva6IKosMRZOpaFWJv3iydfDQ4ovCm7TzU7wx_YNLs9wEkhBfjAf6M4 DBL8KCzHeTECekyUv.jvw5vCoe4JGbRXuW5nUfafLXpOyWtWjayV6B8mi.qC_MH6U40.bEQjL1yL qtqIbOjqYaUudxFiLOSbz6hiwHH2p1FU7J4DxLhvARY1lwZA4xT2Z5IrciZgy11MZNstpy_ZhDFo MJ0FGGwECEEc1_KRvumNu21uN1ZdD_odoJd7r42E5V7fDrW3U13Rrqi0R3.oLdonEbR3fa.oNdSV .z1dfULQXSgkYhR4Y2Iovf9ngayOhXHmIRum7VAPYBZ0vyH7pKgNTapXyqOFXwu5jQnSiwhQPBXD xq05NOoY8Roahrgu24oldabM51871vBiubYi1v_3CpL.jNlNVUsVLGiErq9td_om4gsqY1FjV5.J 2iDVNZRfKSAnCtwyBOWwbt7WjfA2wwmSYKrz.aecnJ4eTbhDw3H9zLqIUK57Mvvx4yvFNPSMKMa_ UfSYglkBzwSAXwbq4waZRdD_IoqeKsNmBGNP68dK6D68ojBQvpa1a_MCtdXhxGy_jXsOYcp0kQLe GcsBGogMQzLyNFPUY5vcZ3hawfQCVAZnQH1Y5KuAeFgHnWEuPMoKouDWxrsnAn5QsHSdE97eOT56 KK5lGrWJzg.i3pmyO.NTJaXuAuxaJYSK5f.4cGdTfhB3eQio5tG3mZu_BkuALNVwt4GpwJ2HDGA. Vfdr9uWWXiGvs1mM1pJc.mWbEzjGbNykeP1ySN6jTev8Kd_ZJfvmKTgm_Pc32A7D8kpxKT9PZSkS XngC1PmrVVRciqTm0mMO7.hXm77i.NtWkdFFOCgeI9L3m9fff.ygn_KrJng76ZNDd44w7Z64c4bb 0dV.YvLjRVrgayBzP3b0CjYXnpznv1hpQB7Mppx51dngE0MNeTewAvWZSbUcco_VgsgiTmmfny4_ VZR.YuXVEUXhh1M.z.ZG0msLcJ3kcygIuJlWDl3UB6P6X6n.7lV8tEQmGsQTU28ar1DazZIXIgZr jjdMUPra9IrJbu8uPVc6Iy_gqxYnF3Xh0dQ28s1Wa9s2.KR1nKf._Wvr4xFGKBDLapAZy1BVW9Uz Idq0kX2kBo4wkLtC_xchC X-Sonic-MF: X-Sonic-ID: f29d7544-4fc9-4e9b-97f7-0e66186135d2 Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Fri, 23 Jan 2026 19:14:22 +0000 Date: Fri, 23 Jan 2026 19:14:18 +0000 (UTC) From: Hannes Domani To: Tom Tromey Cc: "gdb-patches@sourceware.org" Message-ID: <1032595107.6284695.1769195658762@mail.yahoo.com> In-Reply-To: <874iof7xcw.fsf@tromey.com> References: <20260117134052.2660009-1-ssbssa@yahoo.de> <20260117135448.2666604-11-ssbssa@yahoo.de> <874iof7xcw.fsf@tromey.com> Subject: Re: [PATCH v2 11/11] Add aarch64-windows support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.24987 YMailNorrin X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Am Mittwoch, 21. Januar 2026 um 17:18:43 MEZ hat Tom Tromey Folgendes geschrieben: > >>>>> "Hannes" =3D=3D Hannes Domani writes: >=C2=A0 > Hannes> Changes in v2: > Hannes>=C2=A0 - added new source files to ALLDEPFILES > Hannes>=C2=A0 - created NEWS entry > Hannes>=C2=A0 - removed set_gdbarch_auto_wide_charset and set_gdbarch_lon= g_bit calls > Hannes>=C2=A0 =C2=A0 since these are now done in windows-tdep.c > Hannes>=C2=A0 - added comments to aarch64_windows_breakpoint and > Hannes>=C2=A0 =C2=A0 set_gdbarch_decr_pc_after_break > Hannes>=C2=A0 - removed unused 32bit code in > Hannes>=C2=A0 =C2=A0 aarch64_windows_nat_target::fetch_one_register() > Hannes>=C2=A0 - changed stopped_data_address() to stopped_data_addresses(= ) in > Hannes>=C2=A0 =C2=A0 aarch64_windows_nat_target, and updated stopped_by_w= atchpoint() > Hannes>=C2=A0 - initialize windows_process inside INIT_GDB_FILE(aarch64_w= indows_nat) >=C2=A0 > Thank you.=C2=A0 I have a couple of nits but nothing serious. >=C2=A0 > Hannes> +struct aarch64_windows_nat_target final : > Hannes> +=C2=A0 public aarch64_nat_target >=C2=A0 > I guess I'd stick the ":" on the second line, following the operator > rule (even though it's not really an operator). >=C2=A0 > Hannes> +void > Hannes> +aarch64_windows_nat_target::initialize_windows_arch (bool attach= ing) > Hannes> +{ > Hannes> +=C2=A0 memset (&aarch64_windows_process.dr_state, 0, > Hannes> +=C2=A0 =C2=A0 =C2=A0 sizeof (aarch64_windows_process.dr_state)); > Hannes> + > Hannes> +=C2=A0 aarch64_windows_process.mappings=C2=A0 =3D aarch64_mappin= gs; >=C2=A0 > Extra space before the '=3D' here. >=C2=A0 >=C2=A0 > Ok with these nits fixed. > Approved-By: Tom Tromey I've made these changes, thanks. Hannes