[RFA] irix5-nat.c: missing mips-tdep.h #include?

[RFA] irix5-nat.c: missing mips-tdep.h #include?

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

Hello,

GDB has been broken for a while on IRIX, because the compiler could not
find the definitions of mips_regsize() and mips_regnum(). This is
causing the build to fail because the code that uses it in irix5-nat.c
tries to deference the result. The compiler output is as follow:

    irix5-nat.c:58: warning: implicit declaration of function `mips_regsize'
    irix5-nat.c:64: warning: implicit declaration of function `mips_regnum'
    irix5-nat.c:64: invalid type argument of `->'
    irix5-nat.c:66: invalid type argument of `->'
    irix5-nat.c:68: invalid type argument of `->'
    irix5-nat.c:70: invalid type argument of `->'
    (etc...)

I suggest the following change to fix this problem:

2003-12-16  J. Brobecker  <brobecker@gnat.com>

        * irix5-nat.c: Include mips-tdep.h.

OK to apply?

Thanks,
-- 
Joel


[-- Attachment #2: irix5-nat.c.diff --]
[-- Type: text/plain, Size: 460 bytes --]

Index: irix5-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/irix5-nat.c,v
retrieving revision 1.28
diff -u -p -r1.28 irix5-nat.c
--- irix5-nat.c	16 Nov 2003 19:24:04 -0000	1.28
+++ irix5-nat.c	16 Dec 2003 10:40:25 -0000
@@ -36,6 +36,7 @@
 
 /* Prototypes for supply_gregset etc. */
 #include "gregset.h"
+#include "mips-tdep.h"
 
 static void fetch_core_registers (char *, unsigned int, int, CORE_ADDR);
 

Re: [RFA] irix5-nat.c: missing mips-tdep.h #include?

[Kevin Buettner]

On Dec 16,  1:00pm, Joel Brobecker wrote:

> GDB has been broken for a while on IRIX, because the compiler could not
> find the definitions of mips_regsize() and mips_regnum(). This is
> causing the build to fail because the code that uses it in irix5-nat.c
> tries to deference the result. The compiler output is as follow:
> 
>     irix5-nat.c:58: warning: implicit declaration of function `mips_regsize'
>     irix5-nat.c:64: warning: implicit declaration of function `mips_regnum'
>     irix5-nat.c:64: invalid type argument of `->'
>     irix5-nat.c:66: invalid type argument of `->'
>     irix5-nat.c:68: invalid type argument of `->'
>     irix5-nat.c:70: invalid type argument of `->'
>     (etc...)
> 
> I suggest the following change to fix this problem:
> 
> 2003-12-16  J. Brobecker  <brobecker@gnat.com>
> 
>         * irix5-nat.c: Include mips-tdep.h.
> 
> OK to apply?

I think this can go in under the obvious fix rule.

Kevin

Re: [RFA] irix5-nat.c: missing mips-tdep.h #include?

[Joel Brobecker]

> > 2003-12-16  J. Brobecker  <brobecker@gnat.com>
> > 
> >         * irix5-nat.c: Include mips-tdep.h.
> > 
> > OK to apply?
> 
> I think this can go in under the obvious fix rule.

OK, thanks. I am not too familiar with the IRIX port, so I prefered
to ask... 

This has been checked in.

-- 
Joel