From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27321 invoked by alias); 16 Dec 2003 18:17:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27314 invoked from network); 16 Dec 2003 18:17:05 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 16 Dec 2003 18:17:05 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hBGIH5h25148 for ; Tue, 16 Dec 2003 13:17:05 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hBGIH4Y01987; Tue, 16 Dec 2003 13:17:04 -0500 Received: from localhost.localdomain (vpn50-15.rdu.redhat.com [172.16.50.15]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hBGIH46V012305; Tue, 16 Dec 2003 13:17:04 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id hBGIGwL14784; Tue, 16 Dec 2003 11:16:58 -0700 Date: Tue, 16 Dec 2003 18:17:00 -0000 From: Kevin Buettner Message-Id: <1031216181658.ZM14783@localhost.localdomain> In-Reply-To: Joel Brobecker "[RFA] irix5-nat.c: missing mips-tdep.h #include?" (Dec 16, 1:00pm) References: <20031216130021.A28132@gnat.com> To: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA] irix5-nat.c: missing mips-tdep.h #include? MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-12/txt/msg00393.txt.bz2 On Dec 16, 1:00pm, Joel Brobecker wrote: > GDB has been broken for a while on IRIX, because the compiler could not > find the definitions of mips_regsize() and mips_regnum(). This is > causing the build to fail because the code that uses it in irix5-nat.c > tries to deference the result. The compiler output is as follow: > > irix5-nat.c:58: warning: implicit declaration of function `mips_regsize' > irix5-nat.c:64: warning: implicit declaration of function `mips_regnum' > irix5-nat.c:64: invalid type argument of `->' > irix5-nat.c:66: invalid type argument of `->' > irix5-nat.c:68: invalid type argument of `->' > irix5-nat.c:70: invalid type argument of `->' > (etc...) > > I suggest the following change to fix this problem: > > 2003-12-16 J. Brobecker > > * irix5-nat.c: Include mips-tdep.h. > > OK to apply? I think this can go in under the obvious fix rule. Kevin