From: Kevin Buettner <kevinb@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] irix5-nat.c: missing mips-tdep.h #include?
Date: Tue, 16 Dec 2003 18:17:00 -0000 [thread overview]
Message-ID: <1031216181658.ZM14783@localhost.localdomain> (raw)
In-Reply-To: Joel Brobecker <brobecker@gnat.com> "[RFA] irix5-nat.c: missing mips-tdep.h #include?" (Dec 16, 1:00pm)
On Dec 16, 1:00pm, Joel Brobecker wrote:
> GDB has been broken for a while on IRIX, because the compiler could not
> find the definitions of mips_regsize() and mips_regnum(). This is
> causing the build to fail because the code that uses it in irix5-nat.c
> tries to deference the result. The compiler output is as follow:
>
> irix5-nat.c:58: warning: implicit declaration of function `mips_regsize'
> irix5-nat.c:64: warning: implicit declaration of function `mips_regnum'
> irix5-nat.c:64: invalid type argument of `->'
> irix5-nat.c:66: invalid type argument of `->'
> irix5-nat.c:68: invalid type argument of `->'
> irix5-nat.c:70: invalid type argument of `->'
> (etc...)
>
> I suggest the following change to fix this problem:
>
> 2003-12-16 J. Brobecker <brobecker@gnat.com>
>
> * irix5-nat.c: Include mips-tdep.h.
>
> OK to apply?
I think this can go in under the obvious fix rule.
Kevin
next prev parent reply other threads:[~2003-12-16 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-16 18:00 Joel Brobecker
2003-12-16 18:17 ` Kevin Buettner [this message]
2003-12-17 6:27 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031216181658.ZM14783@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox