Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] irix5-nat.c: missing mips-tdep.h #include?
Date: Tue, 16 Dec 2003 18:00:00 -0000	[thread overview]
Message-ID: <20031216130021.A28132@gnat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

Hello,

GDB has been broken for a while on IRIX, because the compiler could not
find the definitions of mips_regsize() and mips_regnum(). This is
causing the build to fail because the code that uses it in irix5-nat.c
tries to deference the result. The compiler output is as follow:

    irix5-nat.c:58: warning: implicit declaration of function `mips_regsize'
    irix5-nat.c:64: warning: implicit declaration of function `mips_regnum'
    irix5-nat.c:64: invalid type argument of `->'
    irix5-nat.c:66: invalid type argument of `->'
    irix5-nat.c:68: invalid type argument of `->'
    irix5-nat.c:70: invalid type argument of `->'
    (etc...)

I suggest the following change to fix this problem:

2003-12-16  J. Brobecker  <brobecker@gnat.com>

        * irix5-nat.c: Include mips-tdep.h.

OK to apply?

Thanks,
-- 
Joel


[-- Attachment #2: irix5-nat.c.diff --]
[-- Type: text/plain, Size: 460 bytes --]

Index: irix5-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/irix5-nat.c,v
retrieving revision 1.28
diff -u -p -r1.28 irix5-nat.c
--- irix5-nat.c	16 Nov 2003 19:24:04 -0000	1.28
+++ irix5-nat.c	16 Dec 2003 10:40:25 -0000
@@ -36,6 +36,7 @@
 
 /* Prototypes for supply_gregset etc. */
 #include "gregset.h"
+#include "mips-tdep.h"
 
 static void fetch_core_registers (char *, unsigned int, int, CORE_ADDR);
 

             reply	other threads:[~2003-12-16 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-16 18:00 Joel Brobecker [this message]
2003-12-16 18:17 ` Kevin Buettner
2003-12-17  6:27   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031216130021.A28132@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox