* cp-names.c vs cp-namespace.c
@ 2005-05-11 20:07 Eli Zaretskii
2005-05-11 20:08 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2005-05-11 20:07 UTC (permalink / raw)
To: gdb-patches
The names of these two files clash in the 8+3 DOS namespace. (The ARI
script does not catch this because cp-names.c is not in the
repository, it is generated during the build.) Can we please rename
cp-names.c to something different, like cp-name-parser.c or some such?
TIA
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cp-names.c vs cp-namespace.c
2005-05-11 20:07 cp-names.c vs cp-namespace.c Eli Zaretskii
@ 2005-05-11 20:08 ` Daniel Jacobowitz
2005-05-11 23:27 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2005-05-11 20:08 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
On Wed, May 11, 2005 at 11:00:47PM +0300, Eli Zaretskii wrote:
> The names of these two files clash in the 8+3 DOS namespace. (The ARI
> script does not catch this because cp-names.c is not in the
> repository, it is generated during the build.) Can we please rename
> cp-names.c to something different, like cp-name-parser.c or some such?
Couldn't you use a separate object directory on DOS, as IIRC we
recommend everyone do? Otherwise I'd have to rename the yacc file, I
think.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cp-names.c vs cp-namespace.c
2005-05-11 20:08 ` Daniel Jacobowitz
@ 2005-05-11 23:27 ` Eli Zaretskii
2005-05-11 23:32 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2005-05-11 23:27 UTC (permalink / raw)
To: gdb-patches
> Date: Wed, 11 May 2005 16:07:17 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
>
> Couldn't you use a separate object directory on DOS, as IIRC we
> recommend everyone do?
That won't help in this case, since cp-names.o and cp-namespace.o will
also clash. Or did I misunderstood what you mean?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cp-names.c vs cp-namespace.c
2005-05-11 23:27 ` Eli Zaretskii
@ 2005-05-11 23:32 ` Daniel Jacobowitz
2005-05-12 16:04 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2005-05-11 23:32 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
On Thu, May 12, 2005 at 02:18:59AM +0300, Eli Zaretskii wrote:
> > Date: Wed, 11 May 2005 16:07:17 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: gdb-patches@sourceware.org
> >
> > Couldn't you use a separate object directory on DOS, as IIRC we
> > recommend everyone do?
>
> That won't help in this case, since cp-names.o and cp-namespace.o will
> also clash. Or did I misunderstood what you mean?
No, you understood me perfectly; I hadn't thought about the object
files. Drat. And I'd just renamed it to avoid the need for this; too
clever for my own good.
I will rename the file tomorrow.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cp-names.c vs cp-namespace.c
2005-05-11 23:32 ` Daniel Jacobowitz
@ 2005-05-12 16:04 ` Daniel Jacobowitz
2005-05-12 16:20 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2005-05-12 16:04 UTC (permalink / raw)
To: gdb-patches; +Cc: Eli Zaretskii
On Wed, May 11, 2005 at 07:31:10PM -0400, Daniel Jacobowitz wrote:
> On Thu, May 12, 2005 at 02:18:59AM +0300, Eli Zaretskii wrote:
> > > Date: Wed, 11 May 2005 16:07:17 -0400
> > > From: Daniel Jacobowitz <drow@false.org>
> > > Cc: gdb-patches@sourceware.org
> > >
> > > Couldn't you use a separate object directory on DOS, as IIRC we
> > > recommend everyone do?
> >
> > That won't help in this case, since cp-names.o and cp-namespace.o will
> > also clash. Or did I misunderstood what you mean?
>
> No, you understood me perfectly; I hadn't thought about the object
> files. Drat. And I'd just renamed it to avoid the need for this; too
> clever for my own good.
>
> I will rename the file tomorrow.
Done like so.
--
Daniel Jacobowitz
CodeSourcery, LLC
2005-05-12 Daniel Jacobowitz <dan@codesourcery.com>
* cp-names.y: Renamed to ...
* cp-name-parser.y: ... this.
* Makefile.in (SFILES, YYFILES, YYOBJ): Rename cp-names.y to
cp-name-parser.y.
(test-cp-names.o): Renamed to test-cp-name-parser.o.
(test-cp-names): Renamed to test-cp-name-parser.
(clean, local-maintainer-clean): Update.
(cp-names.o): Renamed to cp-name-parser.o.
Index: Makefile.in
===================================================================
RCS file: /home/drow/rsync/src/src/gdb/Makefile.in,v
retrieving revision 1.726
diff -u -p -r1.726 Makefile.in
--- Makefile.in 2 May 2005 12:05:11 -0000 1.726
+++ Makefile.in 12 May 2005 13:44:18 -0000
@@ -519,7 +519,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
charset.c cli-out.c coffread.c coff-pe-read.c \
complaints.c completer.c corefile.c \
cp-abi.c cp-support.c cp-namespace.c cp-valprint.c \
- cp-names.y \
+ cp-name-parser.y \
dbxread.c demangle.c dictionary.c disasm.c doublest.c dummy-frame.c \
dwarfread.c dwarf2expr.c dwarf2loc.c dwarf2read.c dwarf2-frame.c \
elfread.c environ.c eval.c event-loop.c event-top.c expprint.c \
@@ -946,13 +946,13 @@ SUBDIRS = @subdirs@
# For now, shortcut the "configure GDB for fewer languages" stuff.
YYFILES = c-exp.c \
- cp-names.c \
+ cp-name-parser.c \
objc-exp.c \
ada-exp.c \
jv-exp.c \
f-exp.c m2-exp.c p-exp.c
YYOBJ = c-exp.o \
- cp-names.o \
+ cp-name-parser.o \
objc-exp.o \
ada-exp.o \
jv-exp.o \
@@ -1084,12 +1084,14 @@ uninstall-tui:
$(DESTDIR)$(man1dir)/$$transformed_name.1
# The C++ name parser can be built standalone for testing.
-test-cp-names.o: cp-names.c $(safe_ctype_h) $(libiberty_h) $(demangle_h)
+test-cp-name-parser.o: cp-name-parser.c $(safe_ctype_h) $(libiberty_h) \
+ $(demangle_h)
$(CC) -c $(INTERNAL_CFLAGS) -DTEST_CPNAMES \
- -o test-cp-names.o cp-names.c
+ -o test-cp-name-parser.o cp-name-parser.c
-test-cp-names$(EXEEXT): test-cp-names.o $(LIBIBERTY)
- $(CC) -o test-cp-names$(EXEEXT) test-cp-names.o $(LIBIBERTY)
+test-cp-name-parser$(EXEEXT): test-cp-name-parser.o $(LIBIBERTY)
+ $(CC_LD) $(INTERNAL_LDFLAGS) -o test-cp-name-parser$(EXEEXT) \
+ test-cp-name-parser.o $(LIBIBERTY)
# We do this by grepping through sources. If that turns out to be too slow,
# maybe we could just require every .o file to have an initialization routine
@@ -1245,7 +1247,7 @@ clean mostlyclean: $(CONFIG_CLEAN)
rm -f init.c version.c
rm -f gdb$(EXEEXT) core make.log
rm -f gdb[0-9]$(EXEEXT)
- rm -f test-cp-names$(EXEEXT)
+ rm -f test-cp-name-parser$(EXEEXT)
.PHONY: clean-tui
clean-tui:
@@ -1274,7 +1276,7 @@ local-maintainer-clean:
@echo "This command is intended for maintainers to use;"
@echo "it deletes files that may require special tools to rebuild."
rm -f c-exp.c \
- cp-names.c \
+ cp-name-parser.c \
ada-lex.c ada-exp.c \
objc-exp.c \
jv-exp.tab \
@@ -1826,7 +1828,7 @@ core-regset.o: core-regset.c $(defs_h) $
$(inferior_h) $(target_h) $(gdb_string_h) $(gregset_h)
cp-abi.o: cp-abi.c $(defs_h) $(value_h) $(cp_abi_h) $(command_h) $(gdbcmd_h) \
$(ui_out_h) $(gdb_string_h)
-cp-names.o: cp-names.c $(safe_ctype_h) $(libiberty_h) $(demangle_h)
+cp-name-parser.o: cp-name-parser.c $(safe_ctype_h) $(libiberty_h) $(demangle_h)
cp-namespace.o: cp-namespace.c $(defs_h) $(cp_support_h) $(gdb_obstack_h) \
$(symtab_h) $(symfile_h) $(gdb_assert_h) $(block_h) $(objfiles_h) \
$(gdbtypes_h) $(dictionary_h) $(command_h) $(frame_h)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cp-names.c vs cp-namespace.c
2005-05-12 16:04 ` Daniel Jacobowitz
@ 2005-05-12 16:20 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2005-05-12 16:20 UTC (permalink / raw)
To: gdb-patches
> Date: Thu, 12 May 2005 12:01:37 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> Done like so.
>
> --
> Daniel Jacobowitz
> CodeSourcery, LLC
>
> 2005-05-12 Daniel Jacobowitz <dan@codesourcery.com>
>
> * cp-names.y: Renamed to ...
> * cp-name-parser.y: ... this.
> * Makefile.in (SFILES, YYFILES, YYOBJ): Rename cp-names.y to
> cp-name-parser.y.
> (test-cp-names.o): Renamed to test-cp-name-parser.o.
> (test-cp-names): Renamed to test-cp-name-parser.
> (clean, local-maintainer-clean): Update.
> (cp-names.o): Renamed to cp-name-parser.o.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-05-12 16:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-11 20:07 cp-names.c vs cp-namespace.c Eli Zaretskii
2005-05-11 20:08 ` Daniel Jacobowitz
2005-05-11 23:27 ` Eli Zaretskii
2005-05-11 23:32 ` Daniel Jacobowitz
2005-05-12 16:04 ` Daniel Jacobowitz
2005-05-12 16:20 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox