* New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt
@ 2013-02-14 2:00 GDB Administrator
2013-02-14 9:59 ` Pierre Muller
0 siblings, 1 reply; 3+ messages in thread
From: GDB Administrator @ 2013-02-14 2:00 UTC (permalink / raw)
To: gdb-patches
1,9d0
< gdb/aarch64-linux-nat.c:146: code: long long: Do not use 'long long', instead use LONGEST
gdb/aarch64-linux-nat.c:146:typedef unsigned long long dr_changed_t;
< gdb/aarch64-linux-nat.c:338: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:338: "\tpid%d, dr_changed_bp=0x%llx, "
< gdb/aarch64-linux-nat.c:339: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:339: "dr_changed_wp=0x%llx\n",
< gdb/aarch64-linux-nat.c:364: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:364: "\tOn exit:\n\tpid%d, dr_changed_bp=0x%llx, "
< gdb/aarch64-linux-nat.c:365: code: %ll: Do not use printf(%ll), instead use printf(%s,phex()) to dump a 'long long' value
gdb/aarch64-linux-nat.c:365: "dr_changed_wp=0x%llx\n",
< gdb/aarch64-linux-nat.c:736: gettext: _ markup: All messages should be marked up with _.
gdb/aarch64-linux-nat.c:736: warning ("Unexpected number of hardware watchpoint registers reported"
< gdb/aarch64-linux-nat.c:744: gettext: _ markup: All messages should be marked up with _.
gdb/aarch64-linux-nat.c:744: warning ("Unable to determine the number of hardware watchpoints"
< gdb/aarch64-linux-nat.c:756: gettext: _ markup: All messages should be marked up with _.
gdb/aarch64-linux-nat.c:756: warning ("Unexpected number of hardware breakpoint registers reported"
< gdb/aarch64-linux-nat.c:764: gettext: _ markup: All messages should be marked up with _.
gdb/aarch64-linux-nat.c:764: warning ("Unable to determine the number of hardware breakpoints"
27a19,20
> gdb/amd64-linux-nat.c:469: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/amd64-linux-nat.c:469: this compatible with older Linux kernels too. */
> gdb/amd64-linux-nat.c:1022: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/amd64-linux-nat.c:1022:/* Get Linux/x86 target description from running target.
320a314,315
> gdb/i386-linux-nat.c:836: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/i386-linux-nat.c:836: this compatible with older Linux kernels too. */
> gdb/i386-linux-nat.c:992: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/i386-linux-nat.c:992:/* Get Linux/x86 target description from running target. */
333,334d327
< gdb/i386-nat.c:225: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/i386-nat.c:225: on fork/vfork/clone. Newer Linux kernels create such tasks with
< gdb/i386-nat.c:230: comment: GNU/Linux: Do not use 'Linux', instead use 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate between the two (this test assumes that word 'Linux' appears on the same line as the word 'GNU' or 'kernel' or a kernel version
gdb/i386-nat.c:230: process to be compatible with the older Linux kernels.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt
2013-02-14 2:00 New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt GDB Administrator
@ 2013-02-14 9:59 ` Pierre Muller
2013-02-14 11:27 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Pierre Muller @ 2013-02-14 9:59 UTC (permalink / raw)
To: gdb-patches
> 320a314,315
> > gdb/i386-linux-nat.c:836: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-linux-nat.c:836: this compatible with older Linux kernels
too.
> */
> > gdb/i386-linux-nat.c:992: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-linux-nat.c:992:/* Get Linux/x86 target description from running
> target. */
These two warnings are just comments moved from
i386-nat.c to i386-linux-nat.c
which seems like a good move indeed.
Moreover, the warning triggers because
'Linux kernels' in not accepted :(
It's easy to allow the plural by changing
pattern:
< && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
---
> && !/(^|[^_[:alnum:]])Linux kernels?([^_[:alnum:]]|$)/ \
But the discussion about removing the 'Linux comment' rule
altogether didn't really come to a definitive conclusion....
Pierre Muller
as ARI maintainer
> 333,334d327
> < gdb/i386-nat.c:225: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-nat.c:225: on fork/vfork/clone. Newer Linux kernels
> create such tasks with
> < gdb/i386-nat.c:230: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-nat.c:230: process to be compatible with the older Linux
> kernels.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt
2013-02-14 9:59 ` Pierre Muller
@ 2013-02-14 11:27 ` Mark Kettenis
0 siblings, 0 replies; 3+ messages in thread
From: Mark Kettenis @ 2013-02-14 11:27 UTC (permalink / raw)
To: pierre.muller; +Cc: gdb-patches
> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Thu, 14 Feb 2013 10:59:13 +0100
>
> But the discussion about removing the 'Linux comment' rule
> altogether didn't really come to a definitive conclusion....
I'm in favour. Those who care can still "fix" these issues, but
having the ARI check things in comments just doesn't make sense.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-14 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-14 2:00 New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt GDB Administrator
2013-02-14 9:59 ` Pierre Muller
2013-02-14 11:27 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox