From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: RE: New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt
Date: Thu, 14 Feb 2013 09:59:00 -0000 [thread overview]
Message-ID: <000301ce0a99$f17761d0$d4662570$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20130214015949.GA27541@sourceware.org>
> 320a314,315
> > gdb/i386-linux-nat.c:836: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-linux-nat.c:836: this compatible with older Linux kernels
too.
> */
> > gdb/i386-linux-nat.c:992: comment: GNU/Linux: Do not use 'Linux',
instead
> use 'Linux kernel' or 'GNU/Linux system'; comments should clearly
> differentiate between the two (this test assumes that word 'Linux' appears
> on the same line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-linux-nat.c:992:/* Get Linux/x86 target description from running
> target. */
These two warnings are just comments moved from
i386-nat.c to i386-linux-nat.c
which seems like a good move indeed.
Moreover, the warning triggers because
'Linux kernels' in not accepted :(
It's easy to allow the plural by changing
pattern:
< && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \
---
> && !/(^|[^_[:alnum:]])Linux kernels?([^_[:alnum:]]|$)/ \
But the discussion about removing the 'Linux comment' rule
altogether didn't really come to a definitive conclusion....
Pierre Muller
as ARI maintainer
> 333,334d327
> < gdb/i386-nat.c:225: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-nat.c:225: on fork/vfork/clone. Newer Linux kernels
> create such tasks with
> < gdb/i386-nat.c:230: comment: GNU/Linux: Do not use 'Linux', instead use
> 'Linux kernel' or 'GNU/Linux system'; comments should clearly
differentiate
> between the two (this test assumes that word 'Linux' appears on the same
> line as the word 'GNU' or 'kernel' or a kernel version
> gdb/i386-nat.c:230: process to be compatible with the older Linux
> kernels.
next prev parent reply other threads:[~2013-02-14 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 2:00 GDB Administrator
2013-02-14 9:59 ` Pierre Muller [this message]
2013-02-14 11:27 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301ce0a99$f17761d0$d4662570$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox