From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32426 invoked by alias); 14 Feb 2013 09:59:20 -0000 Received: (qmail 32417 invoked by uid 22791); 14 Feb 2013 09:59:19 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 09:59:16 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1E9xEFj071409 for ; Thu, 14 Feb 2013 10:59:14 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1E9xEq9031796 for ; Thu, 14 Feb 2013 10:59:14 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r1E9xDGi005055 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Thu, 14 Feb 2013 10:59:13 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <20130214015949.GA27541@sourceware.org> In-Reply-To: <20130214015949.GA27541@sourceware.org> Subject: RE: New ARI warning Thu Feb 14 01:59:49 UTC 2013 in -D 2013-02-14-gmt Date: Thu, 14 Feb 2013 09:59:00 -0000 Message-ID: <000301ce0a99$f17761d0$d4662570$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00340.txt.bz2 > 320a314,315 > > gdb/i386-linux-nat.c:836: comment: GNU/Linux: Do not use 'Linux', instead > use 'Linux kernel' or 'GNU/Linux system'; comments should clearly > differentiate between the two (this test assumes that word 'Linux' appears > on the same line as the word 'GNU' or 'kernel' or a kernel version > gdb/i386-linux-nat.c:836: this compatible with older Linux kernels too. > */ > > gdb/i386-linux-nat.c:992: comment: GNU/Linux: Do not use 'Linux', instead > use 'Linux kernel' or 'GNU/Linux system'; comments should clearly > differentiate between the two (this test assumes that word 'Linux' appears > on the same line as the word 'GNU' or 'kernel' or a kernel version > gdb/i386-linux-nat.c:992:/* Get Linux/x86 target description from running > target. */ These two warnings are just comments moved from i386-nat.c to i386-linux-nat.c which seems like a good move indeed. Moreover, the warning triggers because 'Linux kernels' in not accepted :( It's easy to allow the plural by changing pattern: < && !/(^|[^_[:alnum:]])Linux kernel([^_[:alnum:]]|$)/ \ --- > && !/(^|[^_[:alnum:]])Linux kernels?([^_[:alnum:]]|$)/ \ But the discussion about removing the 'Linux comment' rule altogether didn't really come to a definitive conclusion.... Pierre Muller as ARI maintainer > 333,334d327 > < gdb/i386-nat.c:225: comment: GNU/Linux: Do not use 'Linux', instead use > 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate > between the two (this test assumes that word 'Linux' appears on the same > line as the word 'GNU' or 'kernel' or a kernel version > gdb/i386-nat.c:225: on fork/vfork/clone. Newer Linux kernels > create such tasks with > < gdb/i386-nat.c:230: comment: GNU/Linux: Do not use 'Linux', instead use > 'Linux kernel' or 'GNU/Linux system'; comments should clearly differentiate > between the two (this test assumes that word 'Linux' appears on the same > line as the word 'GNU' or 'kernel' or a kernel version > gdb/i386-nat.c:230: process to be compatible with the older Linux > kernels.