* [ltt-dev] liburcu: likely and unlikely macro collision
[not found] <CAEoG=qO4XivFb9XAkrefF3boVP9uZZYW2ncRKpKvxm6VpZsmyw@mail.gmail.com>
@ 2011-11-01 22:00 ` Mathieu Desnoyers
2011-11-01 23:05 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Desnoyers @ 2011-11-01 22:00 UTC (permalink / raw)
Hi,
likely()/unlikely() seems to be amongst the last macros that urcu
defines that don't have urcu-specific prefixes. Thoughts on whether we
should add a prefix such as caa_likely() and caa_unlikely() are welcome.
Thanks,
Mathieu
* Rafael Fernandez (rfernan3 at illinois.edu) wrote:
> Hi Matthieu,
>
> I am trying to incorporate liburcu in a project I am working with.
> Unfourtunately there are several collisions of the definitions of
> likely and unlikely. Would it be possible for you to add a prefix to
> the macros such that there aren't any collisions? I think it would be
> cleaner/easier for future users to incorporate into existing code
> bases.
>
> Thank you,
> Rafael
>
> --
> Rafael E. Fern?ndez
> B.S. Computer Science
> University of Illinois at Urbana-Champaign
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread* [ltt-dev] liburcu: likely and unlikely macro collision
2011-11-01 22:00 ` [ltt-dev] liburcu: likely and unlikely macro collision Mathieu Desnoyers
@ 2011-11-01 23:05 ` Stephen Hemminger
2011-11-01 23:55 ` Mathieu Desnoyers
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2011-11-01 23:05 UTC (permalink / raw)
> likely()/unlikely() seems to be amongst the last macros that urcu
> defines that don't have urcu-specific prefixes. Thoughts on whether
> we
> should add a prefix such as caa_likely() and caa_unlikely() are
> welcome.
In our usage of liburcu, I had to do macro whacking to workaround
this conflict. Even wrapping the definition in urcu with '#ifndef likely'
would help.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ltt-dev] liburcu: likely and unlikely macro collision
2011-11-01 23:05 ` Stephen Hemminger
@ 2011-11-01 23:55 ` Mathieu Desnoyers
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers @ 2011-11-01 23:55 UTC (permalink / raw)
* Stephen Hemminger (stephen.hemminger at vyatta.com) wrote:
>
> > likely()/unlikely() seems to be amongst the last macros that urcu
> > defines that don't have urcu-specific prefixes. Thoughts on whether
> > we
> > should add a prefix such as caa_likely() and caa_unlikely() are
> > welcome.
>
> In our usage of liburcu, I had to do macro whacking to workaround
> this conflict. Even wrapping the definition in urcu with '#ifndef likely'
> would help.
OK. I'll rename likely/unlikely to caa_likely/caa_unlikely.
commit a0b7f7ea3fc3339a1c42caffd53ce9f056e5b901
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date: Tue Nov 1 19:58:52 2011 -0400
Rename likely/unlikely to caa_likely/caa_unlikely
This fixes namespace conflicts.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Thanks for your feedback!
Mathieu
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-01 23:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAEoG=qO4XivFb9XAkrefF3boVP9uZZYW2ncRKpKvxm6VpZsmyw@mail.gmail.com>
2011-11-01 22:00 ` [ltt-dev] liburcu: likely and unlikely macro collision Mathieu Desnoyers
2011-11-01 23:05 ` Stephen Hemminger
2011-11-01 23:55 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox