From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [ltt-dev] liburcu: likely and unlikely macro collision
Date: Tue, 1 Nov 2011 19:55:02 -0400 [thread overview]
Message-ID: <20111101235502.GA22568@Krystal> (raw)
In-Reply-To: <fc9da044-1918-4936-9d4c-b0a2a8c977cc@tahiti.vyatta.com>
* Stephen Hemminger (stephen.hemminger at vyatta.com) wrote:
>
> > likely()/unlikely() seems to be amongst the last macros that urcu
> > defines that don't have urcu-specific prefixes. Thoughts on whether
> > we
> > should add a prefix such as caa_likely() and caa_unlikely() are
> > welcome.
>
> In our usage of liburcu, I had to do macro whacking to workaround
> this conflict. Even wrapping the definition in urcu with '#ifndef likely'
> would help.
OK. I'll rename likely/unlikely to caa_likely/caa_unlikely.
commit a0b7f7ea3fc3339a1c42caffd53ce9f056e5b901
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date: Tue Nov 1 19:58:52 2011 -0400
Rename likely/unlikely to caa_likely/caa_unlikely
This fixes namespace conflicts.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Thanks for your feedback!
Mathieu
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2011-11-01 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEoG=qO4XivFb9XAkrefF3boVP9uZZYW2ncRKpKvxm6VpZsmyw@mail.gmail.com>
2011-11-01 22:00 ` Mathieu Desnoyers
2011-11-01 23:05 ` Stephen Hemminger
2011-11-01 23:55 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101235502.GA22568@Krystal \
--to=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox