[ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES

[ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES

[KOSAKI Motohiro]

Impact: fix build error

if LTT_KPROBES=y and LTT_TRACEPROBES=m, following build error happend.

  ltt/built-in.o: In function `ltt_specialized_trace':
  ltt/probes/ltt-type-serializer.h:26: undefined reference to `_ltt_specialized_trace'
  make: *** [.tmp_vmlinux1] error 1

In addition, many kernel developer hate "select" syntax. it should be avoided.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 ltt/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ltt/Kconfig b/ltt/Kconfig
index 1d80b98..ef93140 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -196,9 +196,9 @@ config LTT_KPROBES
 	bool "Linux Trace Toolkit Kprobes Support"
 	depends on HAVE_KPROBES
 	depends on LTT_MARKER_CONTROL
+	depends on  LTT_TRACEPROBES=y
 	select KPROBES
 	select KALLSYMS
-	select LTT_TRACEPROBES
 	default y
 	help
 	  Allows connecting the LTTng tracer on kprobes using simple debugfs
-- 
1.6.0.6

[ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES

[Lai Jiangshan]

KOSAKI Motohiro wrote:
> Impact: fix build error
> 
> if LTT_KPROBES=y and LTT_TRACEPROBES=m, following build error happend.
> 
>   ltt/built-in.o: In function `ltt_specialized_trace':
>   ltt/probes/ltt-type-serializer.h:26: undefined reference to `_ltt_specialized_trace'
>   make: *** [.tmp_vmlinux1] error 1
> 
> In addition, many kernel developer hate "select" syntax. it should be avoided.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
> ---
>  ltt/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ltt/Kconfig b/ltt/Kconfig
> index 1d80b98..ef93140 100644
> --- a/ltt/Kconfig
> +++ b/ltt/Kconfig
> @@ -196,9 +196,9 @@ config LTT_KPROBES
>  	bool "Linux Trace Toolkit Kprobes Support"
>  	depends on HAVE_KPROBES
>  	depends on LTT_MARKER_CONTROL
> +	depends on  LTT_TRACEPROBES=y

I encountered this build error before. -:)

I think we should use LTT_SOME_CONFIG for ltt-type-serializer.ko
LTT_TRACEPROBES=y will build 10 or more modules into built-in kernel.

Lai

>  	select KPROBES
>  	select KALLSYMS
> -	select LTT_TRACEPROBES
>  	default y
>  	help
>  	  Allows connecting the LTTng tracer on kprobes using simple debugfs

[ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES

[Mathieu Desnoyers]

* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
> 
> Impact: fix build error
> 
> if LTT_KPROBES=y and LTT_TRACEPROBES=m, following build error happend.
> 
>   ltt/built-in.o: In function `ltt_specialized_trace':
>   ltt/probes/ltt-type-serializer.h:26: undefined reference to `_ltt_specialized_trace'
>   make: *** [.tmp_vmlinux1] error 1
> 

I created a

config LTT_FAST_SERIALIZE
        tristate "Linux Trace Toolkit Custom Serializer"
        default y
        help
          Library for serializing information from custom, efficient, tracepoint
          probes.

which insures LTT_USERSPACE_EVENT and LTT_KPROBES do not depend on
LTT_TRACEPROBES anymore.

Mathieu

> In addition, many kernel developer hate "select" syntax. it should be avoided.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
> ---
>  ltt/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ltt/Kconfig b/ltt/Kconfig
> index 1d80b98..ef93140 100644
> --- a/ltt/Kconfig
> +++ b/ltt/Kconfig
> @@ -196,9 +196,9 @@ config LTT_KPROBES
>  	bool "Linux Trace Toolkit Kprobes Support"
>  	depends on HAVE_KPROBES
>  	depends on LTT_MARKER_CONTROL
> +	depends on  LTT_TRACEPROBES=y
>  	select KPROBES
>  	select KALLSYMS
> -	select LTT_TRACEPROBES
>  	default y
>  	help
>  	  Allows connecting the LTTng tracer on kprobes using simple debugfs
> -- 
> 1.6.0.6
> 
> 
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68