Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: kosaki.motohiro@jp.fujitsu.com (KOSAKI Motohiro)
Subject: [ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES
Date: Tue, 10 Feb 2009 16:43:36 +0900 (JST)	[thread overview]
Message-ID: <20090210164159.6FC5.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)


Impact: fix build error

if LTT_KPROBES=y and LTT_TRACEPROBES=m, following build error happend.

  ltt/built-in.o: In function `ltt_specialized_trace':
  ltt/probes/ltt-type-serializer.h:26: undefined reference to `_ltt_specialized_trace'
  make: *** [.tmp_vmlinux1] error 1

In addition, many kernel developer hate "select" syntax. it should be avoided.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 ltt/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ltt/Kconfig b/ltt/Kconfig
index 1d80b98..ef93140 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -196,9 +196,9 @@ config LTT_KPROBES
 	bool "Linux Trace Toolkit Kprobes Support"
 	depends on HAVE_KPROBES
 	depends on LTT_MARKER_CONTROL
+	depends on  LTT_TRACEPROBES=y
 	select KPROBES
 	select KALLSYMS
-	select LTT_TRACEPROBES
 	default y
 	help
 	  Allows connecting the LTTng tracer on kprobes using simple debugfs
-- 
1.6.0.6







             reply	other threads:[~2009-02-10  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10  7:43 KOSAKI Motohiro [this message]
2009-02-10  8:19 ` Lai Jiangshan
2009-02-11  4:45 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090210164159.6FC5.KOSAKI.MOTOHIRO@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox