From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Subject: [ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES
Date: Tue, 10 Feb 2009 23:45:18 -0500 [thread overview]
Message-ID: <20090211044518.GB6511@Krystal> (raw)
In-Reply-To: <20090210164159.6FC5.KOSAKI.MOTOHIRO@jp.fujitsu.com>
* KOSAKI Motohiro (kosaki.motohiro at jp.fujitsu.com) wrote:
>
> Impact: fix build error
>
> if LTT_KPROBES=y and LTT_TRACEPROBES=m, following build error happend.
>
> ltt/built-in.o: In function `ltt_specialized_trace':
> ltt/probes/ltt-type-serializer.h:26: undefined reference to `_ltt_specialized_trace'
> make: *** [.tmp_vmlinux1] error 1
>
I created a
config LTT_FAST_SERIALIZE
tristate "Linux Trace Toolkit Custom Serializer"
default y
help
Library for serializing information from custom, efficient, tracepoint
probes.
which insures LTT_USERSPACE_EVENT and LTT_KPROBES do not depend on
LTT_TRACEPROBES anymore.
Mathieu
> In addition, many kernel developer hate "select" syntax. it should be avoided.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
> ---
> ltt/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ltt/Kconfig b/ltt/Kconfig
> index 1d80b98..ef93140 100644
> --- a/ltt/Kconfig
> +++ b/ltt/Kconfig
> @@ -196,9 +196,9 @@ config LTT_KPROBES
> bool "Linux Trace Toolkit Kprobes Support"
> depends on HAVE_KPROBES
> depends on LTT_MARKER_CONTROL
> + depends on LTT_TRACEPROBES=y
> select KPROBES
> select KALLSYMS
> - select LTT_TRACEPROBES
> default y
> help
> Allows connecting the LTTng tracer on kprobes using simple debugfs
> --
> 1.6.0.6
>
>
>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
prev parent reply other threads:[~2009-02-11 4:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 7:43 KOSAKI Motohiro
2009-02-10 8:19 ` Lai Jiangshan
2009-02-11 4:45 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211044518.GB6511@Krystal \
--to=compudj@krystal.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox