[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[Nathan Lynch]

An argument of "$2" was added to the prove command line in
tests/run.sh by 68270f0f604e "Mi test: Basic test structure".  This is
harmless since run.sh is never called with more than one argument, but
it is confusing, and it breaks patches in OE that add support for
running tests on the target.

Signed-off-by: Nathan Lynch <nathan_lynch at mentor.com>
---
 tests/run.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/run.sh b/tests/run.sh
index ce51639f7626..c6c50fd9cff9 100755
--- a/tests/run.sh
+++ b/tests/run.sh
@@ -19,4 +19,4 @@
 
 [ -z "$1" ] && echo "Error: No testlist. Please specify a testlist to run." && exit 1
 
-prove $2 --merge --exec '' - < $1
+prove --merge --exec '' - < $1
-- 
1.9.3

[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[Jonathan Rajotte]

Hey

On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch <nathan_lynch at mentor.com>
wrote:

> An argument of "$2" was added to the prove command line in
> tests/run.sh by 68270f0f604e "Mi test: Basic test structure".  This is
> harmless since run.sh is never called with more than one argument, but
>

The multiple arguments could be overcome by adding "" to the multiple test
files list but as you said it is confusing and error prone.

This actually can be used to debug test with a "-v". Or add any basic
arguments to the prove command and was simply convenient at the time.If
this actually break patch from OE ( I assume OE stand for OpenEmbedded and
you are talking about this commit [1])  I'm okai with reverting the change
I introduced.

Thanks
Cheers!

[1]
https://github.com/openembedded/oe-core/commit/d0d184045e8034ddbc77549e681f187e12ab1d08


> it is confusing, and it breaks patches in OE that add support for

running tests on the target.
>
> Signed-off-by: Nathan Lynch <nathan_lynch at mentor.com>
> ---
>  tests/run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/run.sh b/tests/run.sh
> index ce51639f7626..c6c50fd9cff9 100755
> --- a/tests/run.sh
> +++ b/tests/run.sh
> @@ -19,4 +19,4 @@
>
>  [ -z "$1" ] && echo "Error: No testlist. Please specify a testlist to
> run." && exit 1
>
> -prove $2 --merge --exec '' - < $1
> +prove --merge --exec '' - < $1
> --
> 1.9.3
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>



-- 
Jonathan Rajotte Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20141027/a6e0d38a/attachment.html>

[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[Nathan Lynch]

On 10/27/2014 09:38 PM, Jonathan Rajotte wrote:
> Hey
> 
> On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch <nathan_lynch at mentor.com
> <mailto:nathan_lynch at mentor.com>> wrote:
> 
>     An argument of "$2" was added to the prove command line in
>     tests/run.sh by 68270f0f604e "Mi test: Basic test structure".  This is
>     harmless since run.sh is never called with more than one argument, but
> 
> 
> The multiple arguments could be overcome by adding "" to the multiple
> test files list but as you said it is confusing and error prone.  
> 
> This actually can be used to debug test with a "-v". Or add any basic
> arguments to the prove command and was simply convenient at the time.If
> this actually break patch from OE ( I assume OE stand for OpenEmbedded
> and you are talking about this commit [1])  I'm okai with reverting the
> change I introduced.

I didn't intend to imply that upstream LTTng is responsible for keeping
patches working in a downstream project like OE.  I mentioned OE because
that's how my attention was drawn to this change.

If the $2 argument has a legitimate use, I suggest that it be made a bit
more clear since 1) the commit that introduced it didn't mention it at
all, and 2) no code in-tree actually makes use of the extra argument.

I figured it was likely a mistake.

[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[Jonathan Rajotte]

On Tue, Oct 28, 2014 at 12:02 AM, Nathan Lynch <Nathan_Lynch at mentor.com>
wrote:

> On 10/27/2014 09:38 PM, Jonathan Rajotte wrote:
> > Hey
> >
> > On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch <nathan_lynch at mentor.com
> > <mailto:nathan_lynch at mentor.com>> wrote:
> >
> >     An argument of "$2" was added to the prove command line in
> >     tests/run.sh by 68270f0f604e "Mi test: Basic test structure".  This
> is
> >     harmless since run.sh is never called with more than one argument,
> but
> >
> >
> > The multiple arguments could be overcome by adding "" to the multiple
> > test files list but as you said it is confusing and error prone.
> >
> > This actually can be used to debug test with a "-v". Or add any basic
> > arguments to the prove command and was simply convenient at the time.If
> > this actually break patch from OE ( I assume OE stand for OpenEmbedded
> > and you are talking about this commit [1])  I'm okai with reverting the
> > change I introduced.
>
> I didn't intend to imply that upstream LTTng is responsible for keeping
> patches working in a downstream project like OE.  I mentioned OE because
> that's how my attention was drawn to this change.


Did not take it like that :)


>


> If the $2 argument has a legitimate use, I suggest that it be made a bit
> more clear since 1) the commit that introduced it didn't mention it at
> all, and 2) no code in-tree actually makes use of the extra argument.
>
> I figured it was likely a mistake.
>

Which kind of was. This wasn't supposed to be merge and was a mistake on my
part when formatting the patch. It was discussed with David before merging
and we decided to keep it since it was not harmful or *used* and proved
useful. But with the effect it has and unwanted repercussion(confusion,
missing mention in commit etc.) it seems not every aspect where evaluated.
Hence I don't mind this patch and almost welcome it.

Cheers!
-- 
Jonathan R.Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20141028/f83f1500/attachment-0001.html>

[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[David Goulet]

Merged thanks!

David

On 27 Oct (21:00:06), Nathan Lynch wrote:
> An argument of "$2" was added to the prove command line in
> tests/run.sh by 68270f0f604e "Mi test: Basic test structure".  This is
> harmless since run.sh is never called with more than one argument, but
> it is confusing, and it breaks patches in OE that add support for
> running tests on the target.
> 
> Signed-off-by: Nathan Lynch <nathan_lynch at mentor.com>
> ---
>  tests/run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/run.sh b/tests/run.sh
> index ce51639f7626..c6c50fd9cff9 100755
> --- a/tests/run.sh
> +++ b/tests/run.sh
> @@ -19,4 +19,4 @@
>  
>  [ -z "$1" ] && echo "Error: No testlist. Please specify a testlist to run." && exit 1
>  
> -prove $2 --merge --exec '' - < $1
> +prove --merge --exec '' - < $1
> -- 
> 1.9.3
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: Digital signature
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20141029/49ad569a/attachment.sig>