From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan_Lynch@mentor.com (Nathan Lynch) Date: Mon, 27 Oct 2014 23:02:58 -0500 Subject: [lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation In-Reply-To: References: <1414461606-24103-1-git-send-email-nathan_lynch@mentor.com> Message-ID: <544F1572.2040702@mentor.com> On 10/27/2014 09:38 PM, Jonathan Rajotte wrote: > Hey > > On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch > wrote: > > An argument of "$2" was added to the prove command line in > tests/run.sh by 68270f0f604e "Mi test: Basic test structure". This is > harmless since run.sh is never called with more than one argument, but > > > The multiple arguments could be overcome by adding "" to the multiple > test files list but as you said it is confusing and error prone. > > This actually can be used to debug test with a "-v". Or add any basic > arguments to the prove command and was simply convenient at the time.If > this actually break patch from OE ( I assume OE stand for OpenEmbedded > and you are talking about this commit [1]) I'm okai with reverting the > change I introduced. I didn't intend to imply that upstream LTTng is responsible for keeping patches working in a downstream project like OE. I mentioned OE because that's how my attention was drawn to this change. If the $2 argument has a legitimate use, I suggest that it be made a bit more clear since 1) the commit that introduced it didn't mention it at all, and 2) no code in-tree actually makes use of the extra argument. I figured it was likely a mistake.