[lttng-dev] [PATCH] lttng-tools: remove bogus argument from prove invocation

[jonathan.r.julien@gmail.com (Jonathan Rajotte)]

Hey

On Mon, Oct 27, 2014 at 10:00 PM, Nathan Lynch <nathan_lynch at mentor.com>
wrote:

> An argument of "$2" was added to the prove command line in
> tests/run.sh by 68270f0f604e "Mi test: Basic test structure".  This is
> harmless since run.sh is never called with more than one argument, but
>

The multiple arguments could be overcome by adding "" to the multiple test
files list but as you said it is confusing and error prone.

This actually can be used to debug test with a "-v". Or add any basic
arguments to the prove command and was simply convenient at the time.If
this actually break patch from OE ( I assume OE stand for OpenEmbedded and
you are talking about this commit [1])  I'm okai with reverting the change
I introduced.

Thanks
Cheers!

[1]
https://github.com/openembedded/oe-core/commit/d0d184045e8034ddbc77549e681f187e12ab1d08


> it is confusing, and it breaks patches in OE that add support for

running tests on the target.
>
> Signed-off-by: Nathan Lynch <nathan_lynch at mentor.com>
> ---
>  tests/run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/run.sh b/tests/run.sh
> index ce51639f7626..c6c50fd9cff9 100755
> --- a/tests/run.sh
> +++ b/tests/run.sh
> @@ -19,4 +19,4 @@
>
>  [ -z "$1" ] && echo "Error: No testlist. Please specify a testlist to
> run." && exit 1
>
> -prove $2 --merge --exec '' - < $1
> +prove --merge --exec '' - < $1
> --
> 1.9.3
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>



-- 
Jonathan Rajotte Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20141027/a6e0d38a/attachment.html>