Removing deprecated breakpoint functions

Removing deprecated breakpoint functions

[Rob Quill]

Hi,

I am trying to figure out how to remove
deprecated_insert/remove_raw_breakpoint and was wondering if it is
acceptable to substitute a call to them with a call to the
break_command() function as this will handle all the breakpoint chain
related things, or is this function too high level and another one
should be used?

Thanks for your help.

Rob

Re: Removing deprecated breakpoint functions

[Jim Blandy]

"Rob Quill" <rob.quill at gmail.com> writes:
> I am trying to figure out how to remove
> deprecated_insert/remove_raw_breakpoint and was wondering if it is
> acceptable to substitute a call to them with a call to the
> break_command() function as this will handle all the breakpoint chain
> related things, or is this function too high level and another one
> should be used?

Yes, those are too high-level; I think 'set_raw_breakpoint' is more
what you're looking for.  See the uses in breakpoint.c, things like
'create_fork_event_catchpoint' might serve as helpful examples.

Re: Removing deprecated breakpoint functions

[Daniel Jacobowitz]

On Wed, Nov 14, 2007 at 01:45:35PM -0800, Jim Blandy wrote:
> 
> "Rob Quill" <rob.quill at gmail.com> writes:
> > I am trying to figure out how to remove
> > deprecated_insert/remove_raw_breakpoint and was wondering if it is
> > acceptable to substitute a call to them with a call to the
> > break_command() function as this will handle all the breakpoint chain
> > related things, or is this function too high level and another one
> > should be used?
> 
> Yes, those are too high-level; I think 'set_raw_breakpoint' is more
> what you're looking for.  See the uses in breakpoint.c, things like
> 'create_fork_event_catchpoint' might serve as helpful examples.

The breakpoints that use deprecated_insert_raw_breakpoint do not
currently go on the breakpoint chain.  The most important of these
is the software single-step breakpoint.  Nothing is really prepared
to find it on the chain (what priority does it have compared to other
breakpoints, for instance) - so this is going to be a bit tricky.

The other three users are probably simpler to move onto the breakpoint
chain, but they're all on less common platforms.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Removing deprecated breakpoint functions

[Jim Blandy]

Daniel Jacobowitz <drow at false.org> writes:
> On Wed, Nov 14, 2007 at 01:45:35PM -0800, Jim Blandy wrote:
>> 
>> "Rob Quill" <rob.quill at gmail.com> writes:
>> > I am trying to figure out how to remove
>> > deprecated_insert/remove_raw_breakpoint and was wondering if it is
>> > acceptable to substitute a call to them with a call to the
>> > break_command() function as this will handle all the breakpoint chain
>> > related things, or is this function too high level and another one
>> > should be used?
>> 
>> Yes, those are too high-level; I think 'set_raw_breakpoint' is more
>> what you're looking for.  See the uses in breakpoint.c, things like
>> 'create_fork_event_catchpoint' might serve as helpful examples.
>
> The breakpoints that use deprecated_insert_raw_breakpoint do not
> currently go on the breakpoint chain.  The most important of these
> is the software single-step breakpoint.  Nothing is really prepared
> to find it on the chain (what priority does it have compared to other
> breakpoints, for instance) - so this is going to be a bit tricky.

So, bpstat_what and its relatives will need to learn about them?

Re: Removing deprecated breakpoint functions

[Daniel Jacobowitz]

On Wed, Nov 14, 2007 at 02:51:31PM -0800, Jim Blandy wrote:
> So, bpstat_what and its relatives will need to learn about them?

I guess the question is what needs to happen when they're hit, and
whether we can fit them in.

-- 
Daniel Jacobowitz
CodeSourcery