From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19238 invoked by alias); 14 Nov 2007 21:58:57 -0000 Received: (qmail 19229 invoked by uid 22791); 14 Nov 2007 21:58:57 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 14 Nov 2007 21:58:54 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E0ECF9835E; Wed, 14 Nov 2007 21:58:52 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C7904980A7; Wed, 14 Nov 2007 21:58:52 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IsQG3-00010E-QK; Wed, 14 Nov 2007 16:58:51 -0500 Date: Wed, 14 Nov 2007 21:58:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: Rob Quill , gdb@sourceware.org Subject: Re: Removing deprecated breakpoint functions Message-ID: <20071114215851.GA3539@caradoc.them.org> Mail-Followup-To: Jim Blandy , Rob Quill , gdb@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00147.txt.bz2 On Wed, Nov 14, 2007 at 01:45:35PM -0800, Jim Blandy wrote: > > "Rob Quill" writes: > > I am trying to figure out how to remove > > deprecated_insert/remove_raw_breakpoint and was wondering if it is > > acceptable to substitute a call to them with a call to the > > break_command() function as this will handle all the breakpoint chain > > related things, or is this function too high level and another one > > should be used? > > Yes, those are too high-level; I think 'set_raw_breakpoint' is more > what you're looking for. See the uses in breakpoint.c, things like > 'create_fork_event_catchpoint' might serve as helpful examples. The breakpoints that use deprecated_insert_raw_breakpoint do not currently go on the breakpoint chain. The most important of these is the software single-step breakpoint. Nothing is really prepared to find it on the chain (what priority does it have compared to other breakpoints, for instance) - so this is going to be a bit tricky. The other three users are probably simpler to move onto the breakpoint chain, but they're all on less common platforms. -- Daniel Jacobowitz CodeSourcery