From: Jonathan Wakely via Gdb <gdb@sourceware.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Thomas Koenig <tkoenig@netcologne.de>,
Joseph Myers <josmyers@redhat.com>,
gcc@gcc.gnu.org, libc-alpha@sourceware.org,
binutils@sourceware.org, gdb@sourceware.org,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: On pull request workflows for the GNU toolchain
Date: Mon, 23 Sep 2024 16:44:20 +0100 [thread overview]
Message-ID: <CAH6eHdR7bMOL7Up1O35=NigUBgspZEC=0G9TmwtYjMq0nHMV8A@mail.gmail.com> (raw)
In-Reply-To: <87a5fyv1l0.fsf@oldenburg.str.redhat.com>
On Mon, 23 Sept 2024 at 16:20, Florian Weimer wrote:
>
> * Jonathan Wakely:
>
> > The discussion is about how we do patch submission and patch review.
> > The GitHub pull request workflow is widely seen as simpler than our
> > current email-based workflow (not everybody agrees, of course). The
> > idea is to *lower* the barrier of entry for contributors, not raise
> > it.
>
> It should also help those who feel unsure about their use of Git because
> the reviewers see exactly what ends up getting merged (at least with the
> default workflow). With the email-based workflow, that isn't the case,
> and I know it makes some people feel nervous.
Yes, our current workflow is "the patch in your email looks good,
please push what you have in your tree", and what gets pushed could be
different from what was reviewed (probably unintentionally). I don't
think issues caused by this happen often, but a pull-based workflow
can avoid the problem.
next prev parent reply other threads:[~2024-09-23 15:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 15:51 Joseph Myers via Gdb
2024-09-20 18:25 ` Carlos O'Donell via Gdb
2024-09-20 20:41 ` Joseph Myers via Gdb
2024-09-20 21:43 ` Sam James via Gdb
2024-09-20 19:58 ` Matt Rice via Gdb
2024-09-20 20:47 ` Joseph Myers via Gdb
2024-09-23 12:07 ` Thomas Koenig via Gdb
2024-09-23 12:53 ` Jeffrey Walton via Gdb
2024-09-23 13:23 ` Jonathan Wakely via Gdb
2024-09-23 13:36 ` enh via Gdb
2024-09-23 14:33 ` Jonathan Wakely via Gdb
2024-09-23 15:56 ` Iain Sandoe
2024-09-23 15:03 ` Joseph Myers via Gdb
2024-09-23 15:20 ` Florian Weimer via Gdb
2024-09-23 15:44 ` Jonathan Wakely via Gdb [this message]
2024-09-23 17:57 ` Eric Gallager via Gdb
2024-09-23 18:39 ` Jonathan Wakely via Gdb
2024-09-23 18:30 ` Arsen Arsenović via Gdb
2024-09-23 12:56 ` Richard Earnshaw (lists) via Gdb
2024-09-23 14:59 ` Joseph Myers via Gdb
2024-09-24 3:43 ` Jiang, Haochen via Gdb
2024-09-24 16:42 ` Joseph Myers via Gdb
2024-09-25 3:01 ` Jiang, Haochen via Gdb
2024-09-25 14:46 ` Joseph Myers via Gdb
2024-09-26 1:42 ` Jiang, Haochen via Gdb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdR7bMOL7Up1O35=NigUBgspZEC=0G9TmwtYjMq0nHMV8A@mail.gmail.com' \
--to=gdb@sourceware.org \
--cc=binutils@sourceware.org \
--cc=fortran@gcc.gnu.org \
--cc=fweimer@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=josmyers@redhat.com \
--cc=jwakely.gcc@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox