From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CabQJVaN8WYfqDQAWB0awg (envelope-from ) for ; Mon, 23 Sep 2024 11:46:30 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=EC5wbmOa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 863AB1E353; Mon, 23 Sep 2024 11:46:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0C66F1E05C for ; Mon, 23 Sep 2024 11:46:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78F29385840A for ; Mon, 23 Sep 2024 15:46:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78F29385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1727106389; bh=zrulL4FpGP+LAcIG01F2S8E8FeWgtm7zqKQrZ2XrX0M=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=EC5wbmOazYEMzNWZhtszZ1f82wcLYjPrVHa6H5Zjn+A5STgysoFFjSOiRYYoBnFfP sDpF/f2sgEc8wvpJNr1AQrYOVgPWgA5a7pjWhEssrftlaCfEAarO3DeVmxrgUVpwJW EJewnxSl9RzgvKpgK5gCm7wlPMIl+0Z4/vj9Yi8s= Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 62A333858D37; Mon, 23 Sep 2024 15:44:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62A333858D37 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62A333858D37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727106277; cv=none; b=jFygBVshWaO936QuCax6spLadgNoV91Mz3BVjZ+9P0iCfKq8ESJJq4umOvGHBJLkf4pHtNuRXXgbGK3ELY7P2iAmyGDFJfphVQuKD12YnZbOgR5Icez/ZuRjU3SB9Wh+Mo2qE1Zn7fPQXkSsPbm5DELYNnd+/Kn8+1JTFQtBbhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1727106277; c=relaxed/simple; bh=hnnUDA/3993oBweC+KnBv8MGKl1CHCSm4+1Wj6Fdnr4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=FqAvNpOhmxl9SQ/fXcIp789Mfzh6NlzeYy1VtDiktvGeAa2NGhXD0xQkUOwvgfoBiDbVUijzXD26KnQYs4qeNnjcEM7r9EH62a/IRnBKuTuzNDkYQCJBwDISA9NgvpHq4180lly/xjq5qAAtEajnvQZKuUT4mZ0ljehjTph5Xpg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-53659c8d688so3401909e87.1; Mon, 23 Sep 2024 08:44:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727106274; x=1727711074; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zrulL4FpGP+LAcIG01F2S8E8FeWgtm7zqKQrZ2XrX0M=; b=rWgG98Ca3BU82zIs21PZMcyXT4F7Q0Zytze/oXOaMxtbsABIljmZVmouhbV8Fgiw/V X/ehSWvt5INjrcqfTUB+H/xu+EEwCT6MScGqekv6GGCag6x+IYrAZdsBBfoSS/joHJh5 fRpgshhxLvDWxy0fJo8/B6KG8fW0fG2lpG5UFYA5R3d+vb+0AnKFFzqSuaz6c16AyUC2 kO4Bx6S2KZdXEquSj3Id0n1ul4/0+Md0tJiX+kOxcvVGSqiNq5ZfzTYjBtgsLHsr/TIR dBYyqjqgssByuI2uNj0mr9MQF4jPhOfJovCW1MAc+V/1/aYL+J2UEzSsG8gUN8uIlKEJ 3yOw== X-Forwarded-Encrypted: i=1; AJvYcCUIIkl3rBdhC8VUSlBjVxb7U6jIu6JIZFSO68WxSVRMtH9o1fuAN4jeVssBbflmHmBUi9jz15EeoA==@sourceware.org, AJvYcCWoI+W5UBuOv3MpeyWSfW8Dej/YonJjAx5PVc2y46huZICL7NveWKyBzLF2iSt2DU2LNPcduc1ciuvAow==@sourceware.org, AJvYcCXJTj9DF/Ez9hZR8/Rx6W0jZonwShjPBFRdgcpvvok0WFZlt5Yz6M2G7CQ8KnMz1vP0rd+y@sourceware.org X-Gm-Message-State: AOJu0YzlbIW4RD/cMetIf1xJ7ct6PnmDiseJ2yLK8Kg1qG7Qk9Jq1IEg 6eBeb2sQaGxsnVxHeBHBuAlAJ8DKnX7gxOc21g8kPcfCPy2kGCHCQKTyxbA8fzGuwmwogH8icyc 4LwFsBgrUSj5gzdQi9riBxkk5cHQ= X-Google-Smtp-Source: AGHT+IFqYUBaMqKbCA0VNb04CssqDF+mSLGBrOkqKOE2Eb2usqMGCPa6Y4nFAWhaMaz2ogNzu+97BimoopetSKzuoj8= X-Received: by 2002:a05:6512:1055:b0:530:db20:1f15 with SMTP id 2adb3069b0e04-537a68f489emr20621e87.16.1727106273466; Mon, 23 Sep 2024 08:44:33 -0700 (PDT) MIME-Version: 1.0 References: <55715cf9-0f6c-4525-a310-7945db72dc21@netcologne.de> <87a5fyv1l0.fsf@oldenburg.str.redhat.com> In-Reply-To: <87a5fyv1l0.fsf@oldenburg.str.redhat.com> Date: Mon, 23 Sep 2024 16:44:20 +0100 Message-ID: Subject: Re: On pull request workflows for the GNU toolchain To: Florian Weimer Cc: Thomas Koenig , Joseph Myers , gcc@gcc.gnu.org, libc-alpha@sourceware.org, binutils@sourceware.org, gdb@sourceware.org, "fortran@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jonathan Wakely via Gdb Reply-To: Jonathan Wakely Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Mon, 23 Sept 2024 at 16:20, Florian Weimer wrote: > > * Jonathan Wakely: > > > The discussion is about how we do patch submission and patch review. > > The GitHub pull request workflow is widely seen as simpler than our > > current email-based workflow (not everybody agrees, of course). The > > idea is to *lower* the barrier of entry for contributors, not raise > > it. > > It should also help those who feel unsure about their use of Git because > the reviewers see exactly what ends up getting merged (at least with the > default workflow). With the email-based workflow, that isn't the case, > and I know it makes some people feel nervous. Yes, our current workflow is "the patch in your email looks good, please push what you have in your tree", and what gets pushed could be different from what was reviewed (probably unintentionally). I don't think issues caused by this happen often, but a pull-based workflow can avoid the problem.