Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joseph Myers via Gdb <gdb@sourceware.org>
To: "Jiang, Haochen" <haochen.jiang@intel.com>
Cc: "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
	 "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	 "binutils@sourceware.org" <binutils@sourceware.org>,
	 "gdb@sourceware.org" <gdb@sourceware.org>
Subject: RE: On pull request workflows for the GNU toolchain
Date: Tue, 24 Sep 2024 16:42:52 +0000 (UTC)	[thread overview]
Message-ID: <f682dfaf-d260-bb9b-c82b-6514c863a633@redhat.com> (raw)
In-Reply-To: <SA1PR11MB5946DB49C30DE25FF0FBB50BEC682@SA1PR11MB5946.namprd11.prod.outlook.com>

On Tue, 24 Sep 2024, Jiang, Haochen via Gcc wrote:

> I am running regression tests on x86_64 and sending the regressions to
> gcc-regression mailing thread, will I need to send to another place or
> using another API to do that?

I don't expect use of pull requests to change anything about existing 
regression processing that uses mailing lists.  (Systems such as Linaro's 
that identify a specific commit responsible for a regression might wish to 
update the PR accordingly using whatever API is available for posting 
comments on PRs.)

Note the recent discussion of making contrib/test_summary able to submit 
test results to bunsen.

Where projects have existing pre-commit CI that puts CI results in 
patchwork based on patches processed there, I hope such CI would be 
updated to work with pull requests and update the pull requests with such 
CI results.

> > Beyond putting everything through PRs, eventually I'd hope to have
> > merges to mainline normally all go through a CI system that makes sure
> > there are no regressions for at least one configuration before merging
> > changes.
> > 
> 
> CI might take long time if not just building but running regression tests
> from my current experience, it might cause some inconvenience for
> someone who only edits something like MAINTAINER lists.

MAINTAINERS list updates are not urgent, it should be fine for them to 
wait for a batch of approved PRs to pass CI.  (The commit rate in GCC is 
sufficient, and testing sufficiently slow, that I expect a CI system 
managing merges would need to test potential commits to mainline as a 
batch rather than testing every individual commit before it goes in 
mainline.)

> Another question is should we also open a PR for backport commits?

I've left that question open.  I'd hope mainline would eventually move to 
everything going via PRs; other development branches people might freely 
continue to commit directly to, though with the option of using PRs to 
such a branch if the branch maintainers find it useful; and for release 
branches we'd need to consider the best process separately.

> Also for the current commit for obvious, will that policy change?

I wouldn't expect such a policy to change.  With a system of everything 
going through PRs, that would mean anyone with write access could 
approve and merge their own PRs that meet the obvious rule.

-- 
Joseph S. Myers
josmyers@redhat.com


  reply	other threads:[~2024-09-24 16:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 15:51 Joseph Myers via Gdb
2024-09-20 18:25 ` Carlos O'Donell via Gdb
2024-09-20 20:41   ` Joseph Myers via Gdb
2024-09-20 21:43   ` Sam James via Gdb
2024-09-20 19:58 ` Matt Rice via Gdb
2024-09-20 20:47   ` Joseph Myers via Gdb
2024-09-23 12:07 ` Thomas Koenig via Gdb
2024-09-23 12:53   ` Jeffrey Walton via Gdb
2024-09-23 13:23   ` Jonathan Wakely via Gdb
2024-09-23 13:36     ` enh via Gdb
2024-09-23 14:33       ` Jonathan Wakely via Gdb
2024-09-23 15:56         ` Iain Sandoe
2024-09-23 15:03       ` Joseph Myers via Gdb
2024-09-23 15:20     ` Florian Weimer via Gdb
2024-09-23 15:44       ` Jonathan Wakely via Gdb
2024-09-23 17:57   ` Eric Gallager via Gdb
2024-09-23 18:39     ` Jonathan Wakely via Gdb
2024-09-23 18:30   ` Arsen Arsenović via Gdb
2024-09-23 12:56 ` Richard Earnshaw (lists) via Gdb
2024-09-23 14:59   ` Joseph Myers via Gdb
2024-09-24  3:43 ` Jiang, Haochen via Gdb
2024-09-24 16:42   ` Joseph Myers via Gdb [this message]
2024-09-25  3:01     ` Jiang, Haochen via Gdb
2024-09-25 14:46       ` Joseph Myers via Gdb
2024-09-26  1:42         ` Jiang, Haochen via Gdb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f682dfaf-d260-bb9b-c82b-6514c863a633@redhat.com \
    --to=gdb@sourceware.org \
    --cc=binutils@sourceware.org \
    --cc=gcc@gcc.gnu.org \
    --cc=haochen.jiang@intel.com \
    --cc=josmyers@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox