Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joseph Myers via Gdb <gdb@sourceware.org>
To: Matt Rice <ratmice@gmail.com>
Cc: gcc@gcc.gnu.org, libc-alpha@sourceware.org,
	binutils@sourceware.org,  gdb@sourceware.org
Subject: Re: On pull request workflows for the GNU toolchain
Date: Fri, 20 Sep 2024 20:47:38 +0000 (UTC)	[thread overview]
Message-ID: <17236c18-3294-1c2e-c0a6-fb01b5472d48@redhat.com> (raw)
In-Reply-To: <CACTLOFp_Uzbq21Y6TmFtMCB=ARxayrLjvCBqSLkMvwHJd2XOkg@mail.gmail.com>

On Fri, 20 Sep 2024, Matt Rice via Gcc wrote:

> To me though it is nice being able to edit the PR cover letter
> directly in the editor, and do the pull-request using command line
> tools.

In the common case of a single-commit PR without dependencies, it seems 
reasonable to follow the practice that the commit message for the commit 
pushed (to a branch from which the PR is created) is the same as the cover 
letter / PR description (modulo any lines after "---" only being cover 
letter text not intended to go in the final commit on mainline if the PR 
is merged).

Having the ability to create a PR from the command line is desirable - 
it's one part of having a sufficient API (indeed, if cron jobs that commit 
do so via PRs that they self-merge rather than by direct pushes, they'll 
need such an API).  For people not wanting to install extra tools to 
contribute, the web interface for creating a PR is also important.

For people without write access to the main repository to make PRs, the 
"fork the repository and push to a branch in your fork" functionality of 
forges is necessary, just as people can send a patch to the mailing lists 
without having write access.  (And quite likely such forks would be the 
norm for people creating PRs even when they do have write access.)

-- 
Joseph S. Myers
josmyers@redhat.com


  reply	other threads:[~2024-09-20 20:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 15:51 Joseph Myers via Gdb
2024-09-20 18:25 ` Carlos O'Donell via Gdb
2024-09-20 20:41   ` Joseph Myers via Gdb
2024-09-20 21:43   ` Sam James via Gdb
2024-09-20 19:58 ` Matt Rice via Gdb
2024-09-20 20:47   ` Joseph Myers via Gdb [this message]
2024-09-23 12:07 ` Thomas Koenig via Gdb
2024-09-23 12:53   ` Jeffrey Walton via Gdb
2024-09-23 13:23   ` Jonathan Wakely via Gdb
2024-09-23 13:36     ` enh via Gdb
2024-09-23 14:33       ` Jonathan Wakely via Gdb
2024-09-23 15:56         ` Iain Sandoe
2024-09-23 15:03       ` Joseph Myers via Gdb
2024-09-23 15:20     ` Florian Weimer via Gdb
2024-09-23 15:44       ` Jonathan Wakely via Gdb
2024-09-23 17:57   ` Eric Gallager via Gdb
2024-09-23 18:39     ` Jonathan Wakely via Gdb
2024-09-23 18:30   ` Arsen Arsenović via Gdb
2024-09-23 12:56 ` Richard Earnshaw (lists) via Gdb
2024-09-23 14:59   ` Joseph Myers via Gdb
2024-09-24  3:43 ` Jiang, Haochen via Gdb
2024-09-24 16:42   ` Joseph Myers via Gdb
2024-09-25  3:01     ` Jiang, Haochen via Gdb
2024-09-25 14:46       ` Joseph Myers via Gdb
2024-09-26  1:42         ` Jiang, Haochen via Gdb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17236c18-3294-1c2e-c0a6-fb01b5472d48@redhat.com \
    --to=gdb@sourceware.org \
    --cc=binutils@sourceware.org \
    --cc=gcc@gcc.gnu.org \
    --cc=josmyers@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox