From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DeNZG6Df7WbUtzEAWB0awg (envelope-from ) for ; Fri, 20 Sep 2024 16:48:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=wQcCNK38; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4DB1B1E353; Fri, 20 Sep 2024 16:48:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-11.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B63731E08F for ; Fri, 20 Sep 2024 16:48:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23C28385DDCC for ; Fri, 20 Sep 2024 20:48:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23C28385DDCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1726865311; bh=0g90T6yLMsYB13DWly30gtKcWINTW3ZUzVX2BMwtWzs=; h=Date:To:cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=wQcCNK38SIaFq0lq7x0Mglg+E57vbUpsTqr8MEuJoaF0jkHjlDhlFl8+GKpUnmS5f kMtsfvv6UP/ILBwCnXl8kX042FnTmd2DvSq8VAPuVCpnc/80z63iQAUImxFxd6thRT 29sdT9n813k0pAMPJ4KeEwllc1aLgjeXcBbGnqZE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id EB11D3858C50 for ; Fri, 20 Sep 2024 20:47:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB11D3858C50 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB11D3858C50 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726865267; cv=none; b=A0R6oPyFBZ/2ntCpKXHmR30jHzSbYAkX+VVk3fJ/IFIUFLyP0VJ6Xn/v2LkjY8UYTPBT7v9T6800viwT0z64Jg7xoS613b1FzW7vph+zf38w6Rm/6ImkuY0KYtEZJcKzuaN2Kjx9k6qIFmz4E5AmGgApmZOZkdYOXAyL+XOkj7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726865267; c=relaxed/simple; bh=9Qv5Pm5XlaBoRxSecSBjGOMpkFHi3fxBGZzZ54STm44=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=DsjDW4bVmdwC30elXbWF8ZxntFrnA+gxbRFE9iGlJ0yWrgYQbHJ4cW0JZpq5Qan2o7RJoLU7/ASQHthhWjODZ/XQXxaLFLofZuqpSMV0KyeYykBp5SnYlRSEvoXMUoKqIchu7Y9QC35VrzDCIc7DLMyJGYkWvKkIMBUke0UNIdA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-ij7U3Iq6Mh6TIEC-ltOLLA-1; Fri, 20 Sep 2024 16:47:44 -0400 X-MC-Unique: ij7U3Iq6Mh6TIEC-ltOLLA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-374bacd5cccso1302260f8f.1 for ; Fri, 20 Sep 2024 13:47:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726865263; x=1727470063; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0g90T6yLMsYB13DWly30gtKcWINTW3ZUzVX2BMwtWzs=; b=NHWVK6f5bKdA3wXikP8Bci3lL/aTaxaVwZOwzBdt7Wr+JrtPeOS8HUowH3VCIhJQLu Vu34w7Q1h1AO/xKH5I+ab2JDKELMBaItx9+U45ayA3qSe+KESiMaSv+gGT00jdNqLct1 CgvtmsjPVhceylnTyUFzRKU1J3PrECkxvE7O9S4ngAjS1/Q6CDb74uh6K64M1VY1iXzl 0dBeiytm3HC2HWWlXrqwenWZd5uvuYVmm5cdbl99IoNbUN+9QFtcDoO+TA+gsmo574Cx 0YuryJHyQiPkF/0aOKxNsylVFPjICKVhGxiVsGsgj8RxHzU8bdcPyF8xa+JbhsfegHKl a4IQ== X-Forwarded-Encrypted: i=1; AJvYcCU4vZM2mg5CCNMwZSV/4Duw292U+6z+PhVMybwqVTn4Ne/hBCgTiyfXklogAoCMrXENvFs=@sourceware.org X-Gm-Message-State: AOJu0YwXwa36MY+7v/JHaBw4cHKV8MvIuWlCy9RiFkZoTJDhcONDRMoM b8mYDvXebbFYfnwq3mie0604XBndebz9VZ8T4HhvaNYGQaD9RfsC9/RDYfCSyXSQjE2B2E3A/TA MUThKO2VuxuglbTCT4ts81wduH/LiZxxMFjhOskQtNnI+oKFN X-Received: by 2002:a05:6000:1a52:b0:374:c324:eab5 with SMTP id ffacd0b85a97d-37a431ad52fmr2450521f8f.41.1726865263203; Fri, 20 Sep 2024 13:47:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH41S+87GBAslUp2ZVTvcr8go/jV1TRm/1uMakTjnaD8BumF2NNYqtqzXLUaJ2v4OmltctYkg== X-Received: by 2002:a05:6000:1a52:b0:374:c324:eab5 with SMTP id ffacd0b85a97d-37a431ad52fmr2450512f8f.41.1726865262770; Fri, 20 Sep 2024 13:47:42 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73e84a9sm18607287f8f.44.2024.09.20.13.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 13:47:41 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.97) (envelope-from ) id 1srkXS-00000006HT1-2ml8; Fri, 20 Sep 2024 20:47:38 +0000 Date: Fri, 20 Sep 2024 20:47:38 +0000 (UTC) To: Matt Rice cc: gcc@gcc.gnu.org, libc-alpha@sourceware.org, binutils@sourceware.org, gdb@sourceware.org Subject: Re: On pull request workflows for the GNU toolchain In-Reply-To: Message-ID: <17236c18-3294-1c2e-c0a6-fb01b5472d48@redhat.com> References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Joseph Myers via Gdb Reply-To: Joseph Myers Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On Fri, 20 Sep 2024, Matt Rice via Gcc wrote: > To me though it is nice being able to edit the PR cover letter > directly in the editor, and do the pull-request using command line > tools. In the common case of a single-commit PR without dependencies, it seems reasonable to follow the practice that the commit message for the commit pushed (to a branch from which the PR is created) is the same as the cover letter / PR description (modulo any lines after "---" only being cover letter text not intended to go in the final commit on mainline if the PR is merged). Having the ability to create a PR from the command line is desirable - it's one part of having a sufficient API (indeed, if cron jobs that commit do so via PRs that they self-merge rather than by direct pushes, they'll need such an API). For people not wanting to install extra tools to contribute, the web interface for creating a PR is also important. For people without write access to the main repository to make PRs, the "fork the repository and push to a branch in your fork" functionality of forges is necessary, just as people can send a patch to the mailing lists without having write access. (And quite likely such forks would be the norm for people creating PRs even when they do have write access.) -- Joseph S. Myers josmyers@redhat.com