RE: patches for mac support

[<fawzi.mohamed@nokia.com>]

On Friday, June 24, 2011 at 11:38 AM Tristan Gingold [gingold@adacore.com] wrote:

On Jun 23, 2011, at 10:07 PM, Fawzi Mohamed wrote:

> Mohamed,
> 
> First, thank you for this work.

you are welcome

> > I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 .
> > Now I think that I have reached to bottom of it, and I have a set of clean patches that could use a review.
> >
> > Apple gdb simply ignores the eh_frame sections for the libraries without embedded dwarf info, not using eh information (which was the first patch that I submitted) but I find that one should be able to use them, so I looked further and found the "correct" fix.
> > As the path to it was a bit convoluted I have done a few improvements to pieces of code that did fail as consequence of the original bug.
> >
> > The "main" fix is
> >   http://sourceware.org/bugzilla/attachment.cgi?id=5816&action=diff
> > which fixes the mmaped read of sections.
> 
> We (AdaCore) has something very similar in our internal tree.  I very recently worked on submitting a patch to fix this issue.
> The submitted patch was larger as I tried to clean-up this API.

great, I don't care the way it goes, as long as it gets fixed...,
so I suppose I can skip submitting it, unless yours doesn't get accepted.
A pity hat you didn't tell this in the bug, I would have spared some debugging,
I am a lazy guy ;)...

> Note that you need to properly submit your patches: one patch by mail is better (IMHO), patch should be inlined if not large, and
> you need ChangeLog entries.  I suppose the instructions are on the web, also I don't know where.

Pedro Alves answered this, thanks, I am new to submitting to gdb

> > I feel that
> >       http://sourceware.org/bugzilla/attachment.cgi?id=5817
> > which adds a check on the cie pointer is important and improves gdb robustness and should also go in.
> >
> >       http://sourceware.org/bugzilla/attachment.cgi?id=5814
> > adds the forgotten ignore of routine_64 load command, and should also go in
> 
> Note that this should be submitted on the binutils mailing list.

ok I will do...

> >       http://sourceware.org/bugzilla/attachment.cgi?id=5809
> > is something that I have seen apple does and seems reasonable, but I have not needed it, so I am not sure if it should go in
> >
> > I have also noted that compiling gdb I have the following conflict in the grammar, not sure if you are aware of it
> >
> > /bin/sh ../../gdb72/gdb/../ylwrap ../../gdb72/gdb/m2-exp.y y.tab.c m2-exp.c.tmp -- bison -y
> > conflicts: 34 shift/reduce
> > /Users/fawzi/dev/gdb/gdb72Build/gdb/../../gdb72/gdb/m2-exp.y:355.25-44: warning: rule never reduced because of conflicts: @2: /* empty */
> 
> Tristan.

ciao
Fawzi