From: Tristan Gingold <gingold@adacore.com>
To: <fawzi.mohamed@nokia.com> <fawzi.mohamed@nokia.com>
Cc: <gdb@sourceware.org>
Subject: Re: patches for mac support
Date: Mon, 27 Jun 2011 08:59:00 -0000 [thread overview]
Message-ID: <E4B62813-5FAB-4747-A00E-B4830D630C5B@adacore.com> (raw)
In-Reply-To: <3AEF56B29352C444960F3B876394346082CF30@008-AM1MPN1-033.mgdnok.nokia.com>
On Jun 26, 2011, at 2:22 AM, <fawzi.mohamed@nokia.com> <fawzi.mohamed@nokia.com> wrote:
> On Friday, June 24, 2011 at 11:38 AM Tristan Gingold [gingold@adacore.com] wrote:
>
> On Jun 23, 2011, at 10:07 PM, Fawzi Mohamed wrote:
>
>> Mohamed,
>>
>> First, thank you for this work.
>
> you are welcome
>
>>> I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 .
>>> Now I think that I have reached to bottom of it, and I have a set of clean patches that could use a review.
>>>
>>> Apple gdb simply ignores the eh_frame sections for the libraries without embedded dwarf info, not using eh information (which was the first patch that I submitted) but I find that one should be able to use them, so I looked further and found the "correct" fix.
>>> As the path to it was a bit convoluted I have done a few improvements to pieces of code that did fail as consequence of the original bug.
>>>
>>> The "main" fix is
>>> http://sourceware.org/bugzilla/attachment.cgi?id=5816&action=diff
>>> which fixes the mmaped read of sections.
>>
>> We (AdaCore) has something very similar in our internal tree. I very recently worked on submitting a patch to fix this issue.
>> The submitted patch was larger as I tried to clean-up this API.
>
> great, I don't care the way it goes, as long as it gets fixed...,
> so I suppose I can skip submitting it, unless yours doesn't get accepted.
> A pity hat you didn't tell this in the bug, I would have spared some debugging,
I am a lazy guy too :-)
> I am a lazy guy ;)...
Anyway, I have just committed our patch.
BTW, do you (or Nokia) have the FSF copyright assignment ?
Tristan.
next prev parent reply other threads:[~2011-06-27 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 20:07 Fawzi Mohamed
2011-06-24 9:38 ` Tristan Gingold
2011-06-24 11:09 ` Pedro Alves
2011-06-26 0:23 ` fawzi.mohamed
2011-06-27 8:59 ` Tristan Gingold [this message]
2011-06-27 9:18 ` Fawzi Mohamed
2011-06-27 9:46 ` André Pönitz
2011-06-27 15:59 ` Fawzi Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E4B62813-5FAB-4747-A00E-B4830D630C5B@adacore.com \
--to=gingold@adacore.com \
--cc=fawzi.mohamed@nokia.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox