From: Fawzi Mohamed <fawzi.mohamed@nokia.com>
To: gdb@sourceware.org
Subject: patches for mac support
Date: Thu, 23 Jun 2011 20:07:00 -0000 [thread overview]
Message-ID: <9B2A7195-51A9-4F40-97B9-159E041D3174@nokia.com> (raw)
Hi all,
I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 .
Now I think that I have reached to bottom of it, and I have a set of clean patches that could use a review.
Apple gdb simply ignores the eh_frame sections for the libraries without embedded dwarf info, not using eh information (which was the first patch that I submitted) but I find that one should be able to use them, so I looked further and found the "correct" fix.
As the path to it was a bit convoluted I have done a few improvements to pieces of code that did fail as consequence of the original bug.
The "main" fix is
http://sourceware.org/bugzilla/attachment.cgi?id=5816&action=diff
which fixes the mmaped read of sections.
I feel that
http://sourceware.org/bugzilla/attachment.cgi?id=5817
which adds a check on the cie pointer is important and improves gdb robustness and should also go in.
http://sourceware.org/bugzilla/attachment.cgi?id=5814
adds the forgotten ignore of routine_64 load command, and should also go in
http://sourceware.org/bugzilla/attachment.cgi?id=5809
is something that I have seen apple does and seems reasonable, but I have not needed it, so I am not sure if it should go in
I have also noted that compiling gdb I have the following conflict in the grammar, not sure if you are aware of it
/bin/sh ../../gdb72/gdb/../ylwrap ../../gdb72/gdb/m2-exp.y y.tab.c m2-exp.c.tmp -- bison -y
conflicts: 34 shift/reduce
/Users/fawzi/dev/gdb/gdb72Build/gdb/../../gdb72/gdb/m2-exp.y:355.25-44: warning: rule never reduced because of conflicts: @2: /* empty */
ciao
Fawzi
next reply other threads:[~2011-06-23 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 20:07 Fawzi Mohamed [this message]
2011-06-24 9:38 ` Tristan Gingold
2011-06-24 11:09 ` Pedro Alves
2011-06-26 0:23 ` fawzi.mohamed
2011-06-27 8:59 ` Tristan Gingold
2011-06-27 9:18 ` Fawzi Mohamed
2011-06-27 9:46 ` André Pönitz
2011-06-27 15:59 ` Fawzi Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9B2A7195-51A9-4F40-97B9-159E041D3174@nokia.com \
--to=fawzi.mohamed@nokia.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox