From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5744 invoked by alias); 26 Jun 2011 00:23:30 -0000 Received: (qmail 5731 invoked by uid 22791); 26 Jun 2011 00:23:29 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.nokia.com (HELO mgw-da01.nokia.com) (147.243.128.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Jun 2011 00:23:14 +0000 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-da01.nokia.com (Switch-3.4.4/Switch-3.4.3) with ESMTP id p5Q0Mx5o010563; Sun, 26 Jun 2011 03:23:00 +0300 Received: from smtp.mgd.nokia.com ([65.54.30.5]) by vaebh105.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 26 Jun 2011 03:22:59 +0300 Received: from 008-AM1MMR1-001.mgdnok.nokia.com (65.54.30.56) by NOK-am1MHUB-01.mgdnok.nokia.com (65.54.30.5) with Microsoft SMTP Server (TLS) id 8.2.255.0; Sun, 26 Jun 2011 02:22:58 +0200 Received: from 008-AM1MPN1-033.mgdnok.nokia.com ([169.254.3.137]) by 008-AM1MMR1-001.mgdnok.nokia.com ([65.54.30.56]) with mapi id 14.01.0289.008; Sun, 26 Jun 2011 02:22:58 +0200 From: To: CC: Subject: RE: patches for mac support Date: Sun, 26 Jun 2011 00:23:00 -0000 Message-ID: <3AEF56B29352C444960F3B876394346082CF30@008-AM1MPN1-033.mgdnok.nokia.com> References: <9B2A7195-51A9-4F40-97B9-159E041D3174@nokia.com>,<3634A65E-25ED-4F1F-8D22-AD3FCEAF2C9B@adacore.com> In-Reply-To: <3634A65E-25ED-4F1F-8D22-AD3FCEAF2C9B@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Nokia-AV: Clean X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00141.txt.bz2 On Friday, June 24, 2011 at 11:38 AM Tristan Gingold [gingold@adacore.com] = wrote: On Jun 23, 2011, at 10:07 PM, Fawzi Mohamed wrote: > Mohamed, >=20 > First, thank you for this work. you are welcome > > I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=3D1= 1488 . > > Now I think that I have reached to bottom of it, and I have a set of cl= ean patches that could use a review. > > > > Apple gdb simply ignores the eh_frame sections for the libraries withou= t embedded dwarf info, not using eh information (which was the first patch = that I submitted) but I find that one should be able to use them, so I look= ed further and found the "correct" fix. > > As the path to it was a bit convoluted I have done a few improvements t= o pieces of code that did fail as consequence of the original bug. > > > > The "main" fix is > > http://sourceware.org/bugzilla/attachment.cgi?id=3D5816&action=3Ddiff > > which fixes the mmaped read of sections. >=20 > We (AdaCore) has something very similar in our internal tree. I very rec= ently worked on submitting a patch to fix this issue. > The submitted patch was larger as I tried to clean-up this API. great, I don't care the way it goes, as long as it gets fixed..., so I suppose I can skip submitting it, unless yours doesn't get accepted. A pity hat you didn't tell this in the bug, I would have spared some debugg= ing, I am a lazy guy ;)... > Note that you need to properly submit your patches: one patch by mail is = better (IMHO), patch should be inlined if not large, and > you need ChangeLog entries. I suppose the instructions are on the web, a= lso I don't know where. Pedro Alves answered this, thanks, I am new to submitting to gdb > > I feel that > > http://sourceware.org/bugzilla/attachment.cgi?id=3D5817 > > which adds a check on the cie pointer is important and improves gdb rob= ustness and should also go in. > > > > http://sourceware.org/bugzilla/attachment.cgi?id=3D5814 > > adds the forgotten ignore of routine_64 load command, and should also g= o in >=20 > Note that this should be submitted on the binutils mailing list. ok I will do... > > http://sourceware.org/bugzilla/attachment.cgi?id=3D5809 > > is something that I have seen apple does and seems reasonable, but I ha= ve not needed it, so I am not sure if it should go in > > > > I have also noted that compiling gdb I have the following conflict in t= he grammar, not sure if you are aware of it > > > > /bin/sh ../../gdb72/gdb/../ylwrap ../../gdb72/gdb/m2-exp.y y.tab.c m2-e= xp.c.tmp -- bison -y > > conflicts: 34 shift/reduce > > /Users/fawzi/dev/gdb/gdb72Build/gdb/../../gdb72/gdb/m2-exp.y:355.25-44:= warning: rule never reduced because of conflicts: @2: /* empty */ >=20 > Tristan. ciao Fawzi