Mirror of the gdb mailing list
 help / color / mirror / Atom feed
* Commit messages
@ 2014-08-08 12:37 Gary Benson
  2014-08-11  6:12 ` Doug Evans
  0 siblings, 1 reply; 4+ messages in thread
From: Gary Benson @ 2014-08-08 12:37 UTC (permalink / raw)
  To: gdb

Hi everyone,

A bunch of commits just got pushed with bad commit messages.
Please be aware that the format for commit messages is:
 
  One-line summary
  [blank line]
  Description of changes
  [blank line]
  Copy of the ChangeLog entry/entries
 
Thanks,
Gary

-- 
http://gbenson.net/


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Commit messages
  2014-08-08 12:37 Commit messages Gary Benson
@ 2014-08-11  6:12 ` Doug Evans
  2014-08-11 12:24   ` Gary Benson
  0 siblings, 1 reply; 4+ messages in thread
From: Doug Evans @ 2014-08-11  6:12 UTC (permalink / raw)
  To: Gary Benson; +Cc: gdb

On Fri, Aug 8, 2014 at 5:37 AM, Gary Benson <gbenson@redhat.com> wrote:
> Hi everyone,
>
> A bunch of commits just got pushed with bad commit messages.
> Please be aware that the format for commit messages is:
>
>   One-line summary
>   [blank line]
>   Description of changes
>   [blank line]
>   Copy of the ChangeLog entry/entries
>
> Thanks,
> Gary

Best get this written down somewhere as an absolute rule.

Maybe any of (or all of) "Contribution Checklist", "Developer Tips" or
"Coding Standards" from the wiki.
[I didn't see it in any of the above, maybe I missed it or maybe it's
elsewhere.]


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Commit messages
  2014-08-11  6:12 ` Doug Evans
@ 2014-08-11 12:24   ` Gary Benson
  2014-08-11 12:39     ` Gary Benson
  0 siblings, 1 reply; 4+ messages in thread
From: Gary Benson @ 2014-08-11 12:24 UTC (permalink / raw)
  To: Doug Evans; +Cc: gdb

Doug Evans wrote:
> On Fri, Aug 8, 2014 at 5:37 AM, Gary Benson <gbenson@redhat.com> wrote:
> > A bunch of commits just got pushed with bad commit messages.
> > Please be aware that the format for commit messages is:
> >
> >   One-line summary
> >   [blank line]
> >   Description of changes
> >   [blank line]
> >   Copy of the ChangeLog entry/entries
> 
> Best get this written down somewhere as an absolute rule.
> 
> Maybe any of (or all of) "Contribution Checklist", "Developer Tips"
> or "Coding Standards" from the wiki.  [I didn't see it in any of the
> above, maybe I missed it or maybe it's elsewhere.]

Actually I think the only time it was mentioned was here:

  https://sourceware.org/ml/gdb-patches/2014-01/msg00496.html

I'll update the wiki.

Cheers,
Gary

-- 
http://gbenson.net/


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Commit messages
  2014-08-11 12:24   ` Gary Benson
@ 2014-08-11 12:39     ` Gary Benson
  0 siblings, 0 replies; 4+ messages in thread
From: Gary Benson @ 2014-08-11 12:39 UTC (permalink / raw)
  To: Doug Evans; +Cc: gdb

Gary Benson wrote:
> Doug Evans wrote:
> > On Fri, Aug 8, 2014 at 5:37 AM, Gary Benson <gbenson@redhat.com> wrote:
> > > A bunch of commits just got pushed with bad commit messages.
> > > Please be aware that the format for commit messages is:
> > >
> > >   One-line summary
> > >   [blank line]
> > >   Description of changes
> > >   [blank line]
> > >   Copy of the ChangeLog entry/entries
> > 
> > Best get this written down somewhere as an absolute rule.
> > 
> > Maybe any of (or all of) "Contribution Checklist", "Developer
> > Tips" or "Coding Standards" from the wiki.  [I didn't see it in
> > any of the above, maybe I missed it or maybe it's elsewhere.]
> 
> Actually I think the only time it was mentioned was here:
> 
>   https://sourceware.org/ml/gdb-patches/2014-01/msg00496.html
> 
> I'll update the wiki.

https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages

Cheers,
Gary

-- 
http://gbenson.net/


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-11 12:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-08 12:37 Commit messages Gary Benson
2014-08-11  6:12 ` Doug Evans
2014-08-11 12:24   ` Gary Benson
2014-08-11 12:39     ` Gary Benson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox