From: Gary Benson <gbenson@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb@sourceware.org
Subject: Re: Commit messages
Date: Mon, 11 Aug 2014 12:39:00 -0000 [thread overview]
Message-ID: <20140811123947.GA14132@blade.nx> (raw)
In-Reply-To: <20140811122418.GA5466@blade.nx>
Gary Benson wrote:
> Doug Evans wrote:
> > On Fri, Aug 8, 2014 at 5:37 AM, Gary Benson <gbenson@redhat.com> wrote:
> > > A bunch of commits just got pushed with bad commit messages.
> > > Please be aware that the format for commit messages is:
> > >
> > > One-line summary
> > > [blank line]
> > > Description of changes
> > > [blank line]
> > > Copy of the ChangeLog entry/entries
> >
> > Best get this written down somewhere as an absolute rule.
> >
> > Maybe any of (or all of) "Contribution Checklist", "Developer
> > Tips" or "Coding Standards" from the wiki. [I didn't see it in
> > any of the above, maybe I missed it or maybe it's elsewhere.]
>
> Actually I think the only time it was mentioned was here:
>
> https://sourceware.org/ml/gdb-patches/2014-01/msg00496.html
>
> I'll update the wiki.
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages
Cheers,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2014-08-11 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 12:37 Gary Benson
2014-08-11 6:12 ` Doug Evans
2014-08-11 12:24 ` Gary Benson
2014-08-11 12:39 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811123947.GA14132@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox