From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27976 invoked by alias); 11 Aug 2014 12:39:53 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 27965 invoked by uid 89); 11 Aug 2014 12:39:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Aug 2014 12:39:52 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7BCdnjV010388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Aug 2014 08:39:49 -0400 Received: from blade.nx (ovpn-116-99.ams2.redhat.com [10.36.116.99]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7BCdmfH025374; Mon, 11 Aug 2014 08:39:49 -0400 Received: by blade.nx (Postfix, from userid 1000) id 055092640E3; Mon, 11 Aug 2014 13:39:47 +0100 (BST) Date: Mon, 11 Aug 2014 12:39:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb@sourceware.org Subject: Re: Commit messages Message-ID: <20140811123947.GA14132@blade.nx> References: <20140808123738.GC18439@blade.nx> <20140811122418.GA5466@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140811122418.GA5466@blade.nx> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00013.txt.bz2 Gary Benson wrote: > Doug Evans wrote: > > On Fri, Aug 8, 2014 at 5:37 AM, Gary Benson wrote: > > > A bunch of commits just got pushed with bad commit messages. > > > Please be aware that the format for commit messages is: > > > > > > One-line summary > > > [blank line] > > > Description of changes > > > [blank line] > > > Copy of the ChangeLog entry/entries > > > > Best get this written down somewhere as an absolute rule. > > > > Maybe any of (or all of) "Contribution Checklist", "Developer > > Tips" or "Coding Standards" from the wiki. [I didn't see it in > > any of the above, maybe I missed it or maybe it's elsewhere.] > > Actually I think the only time it was mentioned was here: > > https://sourceware.org/ml/gdb-patches/2014-01/msg00496.html > > I'll update the wiki. https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages Cheers, Gary -- http://gbenson.net/