Does m68klinux-tdep.c handle uclinux too

Does m68klinux-tdep.c handle uclinux too

[Vladimir Prus]

Hi,

looking at m68klinux-tdep.c, I see this:

  if (target_is_uclinux == -1)
    {
      /* Determine whether we are running on a uClinux or normal GNU/Linux
         target so we can use the correct sigcontext layouts.  */
      CORE_ADDR dummy;

      target_is_uclinux
        = (target_auxv_search (&current_target, AT_NULL, &dummy) > 0
	   && target_auxv_search (&current_target, AT_PAGESZ, &dummy) == 0);
    }

However, looking at configure.tgt, I see:

m68*-*-aout* | m68*-*-coff* | m68*-*-elf* | m68*-*-rtems* | m68*-*-uclinux* | \
fido-*-elf*)
	# Target: Motorola m68k embedded (e.g. bug monitors)
	gdb_target_obs="m68k-tdep.o monitor.o dbug-rom.o dsrec.o"
	;;


So, it seems that m68klinux-tdep.c is not even compiled for uclinux target.
Then, is something here that needs fixing?

- Volodya

Re: Does m68klinux-tdep.c handle uclinux too

[Vladimir Prus]

On Thursday 10 December 2009 12:52:29 Vladimir Prus wrote:

> 
> Hi,
> 
> looking at m68klinux-tdep.c, I see this:
> 
>   if (target_is_uclinux == -1)
>     {
>       /* Determine whether we are running on a uClinux or normal GNU/Linux
>          target so we can use the correct sigcontext layouts.  */
>       CORE_ADDR dummy;
> 
>       target_is_uclinux
>         = (target_auxv_search (&current_target, AT_NULL, &dummy) > 0
> 	   && target_auxv_search (&current_target, AT_PAGESZ, &dummy) == 0);
>     }
> 
> However, looking at configure.tgt, I see:
> 
> m68*-*-aout* | m68*-*-coff* | m68*-*-elf* | m68*-*-rtems* | m68*-*-uclinux* | \
> fido-*-elf*)
> 	# Target: Motorola m68k embedded (e.g. bug monitors)
> 	gdb_target_obs="m68k-tdep.o monitor.o dbug-rom.o dsrec.o"
> 	;;
> 
> 
> So, it seems that m68klinux-tdep.c is not even compiled for uclinux target.
> Then, is something here that needs fixing?

FWIW, below is a local patch that we have. Does it seem reasonable?

- Volodya

--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -280,12 +280,12 @@ m68hc11*-*-*|m6811*-*-*)
        gdb_sim=../sim/m68hc11/libsim.a
        ;;

-m68*-*-aout* | m68*-*-coff* | m68*-*-elf* | m68*-*-rtems* | m68*-*-uclinux* | \
+m68*-*-aout* | m68*-*-coff* | m68*-*-elf* | m68*-*-rtems* | \
 fido-*-elf*)
        # Target: Motorola m68k embedded (e.g. bug monitors)
        gdb_target_obs="m68k-tdep.o monitor.o dbug-rom.o dsrec.o"
        ;;
-m68*-*-linux*)
+m68*-*-linux* | m68*-*-uclinux*)
        # Target: Motorola m68k with a.out and ELF
        gdb_target_obs="m68k-tdep.o m68klinux-tdep.o solib.o solib-svr4.o \
                        glibc-tdep.o symfile-mem.o"
@@ -616,6 +616,7 @@ esac
 case "${targ}" in
 *-*-freebsd*)  gdb_osabi=GDB_OSABI_FREEBSD_ELF ;;
 *-*-linux*)    gdb_osabi=GDB_OSABI_LINUX ;;
+*-*-uclinux*)  gdb_osabi=GDB_OSABI_LINUX ;;
 *-*-nto*)      gdb_osabi=GDB_OSABI_QNXNTO ;;
 m68*-*-openbsd* | m88*-*-openbsd* | vax-*-openbsd*) ;;
 *-*-openbsd*)  gdb_osabi=GDB_OSABI_OPENBSD_ELF ;;

Re: Does m68klinux-tdep.c handle uclinux too

[Daniel Jacobowitz]

On Thu, Dec 10, 2009 at 02:13:13PM +0300, Vladimir Prus wrote:
> > looking at m68klinux-tdep.c, I see this:
> > 
> >   if (target_is_uclinux == -1)
> >     {
> >       /* Determine whether we are running on a uClinux or normal GNU/Linux
> >          target so we can use the correct sigcontext layouts.  */
> >       CORE_ADDR dummy;
> > 
> >       target_is_uclinux
> >         = (target_auxv_search (&current_target, AT_NULL, &dummy) > 0
> > 	   && target_auxv_search (&current_target, AT_PAGESZ, &dummy) == 0);
> >     }

I think I or someone else at CodeSourcery wrote that.  So it was
probably submitted from our internal tree.

> FWIW, below is a local patch that we have. Does it seem reasonable?

IMO this is OK.

It would also be OK to have just m68k-tdep.o and m68klinux-tdep.o.
GDB doesn't support m68k uclinux shared libraries.

-- 
Daniel Jacobowitz
CodeSourcery