Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb@sources.redhat.com
Subject: Re: Does m68klinux-tdep.c handle uclinux too
Date: Thu, 10 Dec 2009 14:05:00 -0000	[thread overview]
Message-ID: <20091210140519.GA32131@caradoc.them.org> (raw)
In-Reply-To: <200912101413.13246.vladimir@codesourcery.com>

On Thu, Dec 10, 2009 at 02:13:13PM +0300, Vladimir Prus wrote:
> > looking at m68klinux-tdep.c, I see this:
> > 
> >   if (target_is_uclinux == -1)
> >     {
> >       /* Determine whether we are running on a uClinux or normal GNU/Linux
> >          target so we can use the correct sigcontext layouts.  */
> >       CORE_ADDR dummy;
> > 
> >       target_is_uclinux
> >         = (target_auxv_search (&current_target, AT_NULL, &dummy) > 0
> > 	   && target_auxv_search (&current_target, AT_PAGESZ, &dummy) == 0);
> >     }

I think I or someone else at CodeSourcery wrote that.  So it was
probably submitted from our internal tree.

> FWIW, below is a local patch that we have. Does it seem reasonable?

IMO this is OK.

It would also be OK to have just m68k-tdep.o and m68klinux-tdep.o.
GDB doesn't support m68k uclinux shared libraries.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2009-12-10 14:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10  9:52 Vladimir Prus
2009-12-10 11:13 ` Vladimir Prus
2009-12-10 14:05   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091210140519.GA32131@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox