Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Eli Zaretskii <eliz@gnu.org>, Vladimir Prus <ghost@cs.msu.su>,
		gdb@sources.redhat.com
Subject: Re: MI: "^running" issues
Date: Sat, 08 Sep 2007 07:21:00 -0000	[thread overview]
Message-ID: <20070908034513.GA32442@caradoc.them.org> (raw)
In-Reply-To: <18145.60697.604974.652756@kahikatea.snap.net.nz>

On Sat, Sep 08, 2007 at 12:30:17PM +1200, Nick Roberts wrote:
>  > We're in a tricky situation.  The developers of async mode were
>  > respected contributors - but they're not here any more to explain
>  > their work.  It doesn't work as-is, so we can't test it.  And Nick's
>  > patches to bring it into shape require someone who really understands
>  > what they're doing to review them.  That's not going to be me, since I
>  > couldn't figure the patches out when I last tried.
> 
> I don't really see much difference between GDB having code that we don't fully
> understand, and installing code that we don't fully understand to use it: in
> both cases we rely on the testsuite.  The difference being that, if my changes
> are installed, asynchronous operation will get tested and over time the code
> will improve.

When the code was originally installed, by its authors, they
understood it.  By committing it, they declared that it was right
(at the time, in the current context, et cetera).  Code that we
don't understand doesn't have that assurance.

I think it's a pretty big difference, but as I said, I am not likely
to review such patches myself since I don't understand them.  And I'm
trying to cut back on the time I spent on review over the past few
years.  If another maintainer reviews them and has a different
opinion, I'm not going to get in the way.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-09-08  3:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-04 12:53 Vladimir Prus
2007-09-05  5:24 ` Nick Roberts
2007-09-05  5:39   ` Vladimir Prus
2007-09-05  6:25     ` Nick Roberts
2007-09-05 17:27     ` Eli Zaretskii
2007-09-05 18:42       ` Vladimir Prus
2007-09-06  6:46         ` Eli Zaretskii
2007-09-06  7:20           ` Vladimir Prus
2007-09-06  8:12             ` Fabian Cenedese
2007-09-06  8:24               ` Mark Kettenis
2007-09-06 11:39                 ` Nick Roberts
2007-09-06 21:18               ` Vladimir Prus
2007-09-06 14:38             ` Bob Rossi
2007-09-06 15:06               ` Vladimir Prus
2007-09-06 19:34             ` Eli Zaretskii
2007-09-06 19:38               ` Vladimir Prus
2007-09-07  9:04                 ` Eli Zaretskii
2007-09-07  9:15                   ` Nick Roberts
2007-09-07 10:59                     ` Vladimir Prus
2007-09-07 18:06                       ` Eli Zaretskii
2007-09-07 18:18                         ` Daniel Jacobowitz
2007-09-07 18:24                           ` Eli Zaretskii
2007-09-08  0:30                             ` Daniel Jacobowitz
2007-09-08  3:45                           ` Nick Roberts
2007-09-08  7:21                             ` Daniel Jacobowitz [this message]
2007-09-09 20:10                       ` Nick Roberts
2007-09-07  8:11             ` Nick Roberts
2007-09-06 15:03         ` Jim Blandy
2007-09-06 18:08         ` Jim Ingham
2007-09-06 18:34           ` Vladimir Prus
2007-09-06 18:41             ` Jim Ingham
2007-09-06 18:48               ` Vladimir Prus
2007-09-07  5:54                 ` André Pönitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070908034513.GA32442@caradoc.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox