Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb@sources.redhat.com
Subject: Re: MI: "^running" issues
Date: Sun, 09 Sep 2007 20:10:00 -0000	[thread overview]
Message-ID: <18146.36234.394471.602914@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200709071404.14065.ghost@cs.msu.su>

 > > I've run Vladimir's example under GDB with my async patch and it also
 > > printed a ^running record and no *stopped, so perhaps ^running should
 > > indeed be printed later.  However, the best way to get the right
 > > asynchronous MI output is probably to develop this code.
 > 
 > Why? It seems to me that outputting "^running" only when the target is
 > running is completely different matter from being able to enter more
 > commands when the target is running. 

I mean more generally than when "^running" is printed, e.g. "next" returning
"^done" instead of "*stopped".

 >                                      I don't see why we can fix "^running"
 > now, so that folks who are either not interested in asynchronous mode, or
 > don't like to wait for it, can get right behaviour now?

If there is a simple fix then it can only make sense.  However, I dont think
this should require removing existing async code.

 >...
 > Assuming that 
 > 
 > 	http://sourceware.org/ml/gdb-patches/2006-11/msg00225.html
 > 	http://thread.gmane.org/gmane.comp.gdb.patches/31081
 > 
 > are the most recent discussions about your patch, it does not seems like
 > "copied verbatim from Apple" is the problem. The problem is that is a big
 > patch,

diffstat (without ChangeLog) gives something like:

 20 files changed, 388 insertions, 25 deletions, 221 modifications

 > and:
 > 
 > 	- I can't find high-level overview of what the patch is trying
 > 	to do, and how it changes gdb behaviour. While a doc patch
 > 	might be premature, some text file would be great.

I've already spent a lot of time on this patch and don't plan to spend much
more when there is no maintainer willing/able to review it.  I'll just keep it
in sync with the repository and maybe look at it more closely again if interest
increases.

 > 	- There are no tests to come with the patch, which makes it
 > 	even harder to understand what are you aiming at.

There's a test attached to msg00225.html listed above.  Also, as I think I've
said before, to run testsuite with the asynchronous event loop just put the
line:

set GDBFLAGS "--async"

at the bottom of site.exp.

at the end of site.exp for the tests.  Asynchronous output from MI requires
new tests but I haven't included these in the diff.

 > That's pretty much what I was complaining recently -- without a design
 > doc for async mode it's not only impossible to understand the existing
 > code, but it's also impossible to understand the code that you're proposing.

I can't write a design doc for code that others have already written.  It
doesn't make it impossible to understand, just more difficult.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  parent reply	other threads:[~2007-09-08 11:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-04 12:53 Vladimir Prus
2007-09-05  5:24 ` Nick Roberts
2007-09-05  5:39   ` Vladimir Prus
2007-09-05  6:25     ` Nick Roberts
2007-09-05 17:27     ` Eli Zaretskii
2007-09-05 18:42       ` Vladimir Prus
2007-09-06  6:46         ` Eli Zaretskii
2007-09-06  7:20           ` Vladimir Prus
2007-09-06  8:12             ` Fabian Cenedese
2007-09-06  8:24               ` Mark Kettenis
2007-09-06 11:39                 ` Nick Roberts
2007-09-06 21:18               ` Vladimir Prus
2007-09-06 14:38             ` Bob Rossi
2007-09-06 15:06               ` Vladimir Prus
2007-09-06 19:34             ` Eli Zaretskii
2007-09-06 19:38               ` Vladimir Prus
2007-09-07  9:04                 ` Eli Zaretskii
2007-09-07  9:15                   ` Nick Roberts
2007-09-07 10:59                     ` Vladimir Prus
2007-09-07 18:06                       ` Eli Zaretskii
2007-09-07 18:18                         ` Daniel Jacobowitz
2007-09-07 18:24                           ` Eli Zaretskii
2007-09-08  0:30                             ` Daniel Jacobowitz
2007-09-08  3:45                           ` Nick Roberts
2007-09-08  7:21                             ` Daniel Jacobowitz
2007-09-09 20:10                       ` Nick Roberts [this message]
2007-09-07  8:11             ` Nick Roberts
2007-09-06 15:03         ` Jim Blandy
2007-09-06 18:08         ` Jim Ingham
2007-09-06 18:34           ` Vladimir Prus
2007-09-06 18:41             ` Jim Ingham
2007-09-06 18:48               ` Vladimir Prus
2007-09-07  5:54                 ` André Pönitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18146.36234.394471.602914@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=eliz@gnu.org \
    --cc=gdb@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox