Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Eli Zaretskii <eliz@gnu.org>,  gdb@sources.redhat.com
Subject: Re: MI: "^running" issues
Date: Fri, 07 Sep 2007 10:59:00 -0000	[thread overview]
Message-ID: <200709071404.14065.ghost@cs.msu.su> (raw)
In-Reply-To: <18145.5117.427647.382269@kahikatea.snap.net.nz>

On Friday 07 September 2007 13:03:57 Nick Roberts wrote:
>  > > The code related to that bug has something to do with async mode,
>  > > but it's pretty unclear why it should be, and how would I test
>  > > that my fixes don't break that async mode.
>  > 
>  > Well, Nick is trying to improve on the async code, perhaps he could
>  > help understand the offending code and find the right fix for the
>  > problem you found.
> 
> I've run Vladimir's example under GDB with my async patch and it also printed a
> ^running record and no *stopped, so perhaps ^running should indeed be printed
> later.  However, the best way to get the right asynchronous MI output is
> probably to develop this code.

Why? It seems to me that outputting "^running" only when the target is
running is completely different matter from being able to enter more
commands when the target is running. I don't see why we can fix "^running" now,
so that folks who are either not interested in asynchronous mode, or don't
like to wait for it, can get right behaviour now?

> I could create another branch for it but I suspect that it wouldn't get looked
> at.  I would like to commit it to mainline after the release but Daniel doesn't
> like this idea as some changes are copied verbatim from Apple.  However, I've
> tried to confine these changes to the "--async" option so that usual
> (synchronous) operation is unchanged.
 
Assuming that 

	http://sourceware.org/ml/gdb-patches/2006-11/msg00225.html
	http://thread.gmane.org/gmane.comp.gdb.patches/31081

are the most recent discussions about your patch, it does not seems like
"copied verbatim from Apple" is the problem. The problem is that is a big patch,
and:

	- I can't find high-level overview of what the patch is trying
	to do, and how it changes gdb behaviour. While a doc patch
	might be premature, some text file would be great.
	- There are no tests to come with the patch, which makes it
	even harder to understand what are you aiming at.

That's pretty much what I was complaining recently -- without a design
doc for async mode it's not only impossible to understand the existing
code, but it's also impossible to understand the code that you're proposing.

- Volodya


  reply	other threads:[~2007-09-07 10:04 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-04 12:53 Vladimir Prus
2007-09-05  5:24 ` Nick Roberts
2007-09-05  5:39   ` Vladimir Prus
2007-09-05  6:25     ` Nick Roberts
2007-09-05 17:27     ` Eli Zaretskii
2007-09-05 18:42       ` Vladimir Prus
2007-09-06  6:46         ` Eli Zaretskii
2007-09-06  7:20           ` Vladimir Prus
2007-09-06  8:12             ` Fabian Cenedese
2007-09-06  8:24               ` Mark Kettenis
2007-09-06 11:39                 ` Nick Roberts
2007-09-06 21:18               ` Vladimir Prus
2007-09-06 14:38             ` Bob Rossi
2007-09-06 15:06               ` Vladimir Prus
2007-09-06 19:34             ` Eli Zaretskii
2007-09-06 19:38               ` Vladimir Prus
2007-09-07  9:04                 ` Eli Zaretskii
2007-09-07  9:15                   ` Nick Roberts
2007-09-07 10:59                     ` Vladimir Prus [this message]
2007-09-07 18:06                       ` Eli Zaretskii
2007-09-07 18:18                         ` Daniel Jacobowitz
2007-09-07 18:24                           ` Eli Zaretskii
2007-09-08  0:30                             ` Daniel Jacobowitz
2007-09-08  3:45                           ` Nick Roberts
2007-09-08  7:21                             ` Daniel Jacobowitz
2007-09-09 20:10                       ` Nick Roberts
2007-09-07  8:11             ` Nick Roberts
2007-09-06 15:03         ` Jim Blandy
2007-09-06 18:08         ` Jim Ingham
2007-09-06 18:34           ` Vladimir Prus
2007-09-06 18:41             ` Jim Ingham
2007-09-06 18:48               ` Vladimir Prus
2007-09-07  5:54                 ` André Pönitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709071404.14065.ghost@cs.msu.su \
    --to=ghost@cs.msu.su \
    --cc=eliz@gnu.org \
    --cc=gdb@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox