Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: cgd@broadcom.com
To: "Eric Christopher" <echristo@redhat.com>
Cc: aoliva@redhat.com, fche@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: MIPS simulator initializes LSI pmon vector table with code
Date: Fri, 19 Apr 2002 12:06:00 -0000	[thread overview]
Message-ID: <yov5y9fjo6dd.fsf@broadcom.com> (raw)
In-Reply-To: "Eric Christopher"'s message of "19 Apr 2002 11:34:58 -0700"

At 19 Apr 2002 11:34:58 -0700, Eric Christopher wrote:
> This was support that worked a while back and the change that Alex is
> reverting broke the LSI support. We aren't supporting something new,
> we're fixing something that someone else broke :)

well, at some point in time perhaps.

it looks like this code has been in the public cvs tree in some form
forever.

rev 1.1 did code like this, but it was moved in rev 1.2 (by fche) to
later in the function and made conditional on perhaps the wrong
variables.


"change that Alex is reverting" isn't a good description: if he
actually had reverted the change that put those there, he would have
put those calls back in their original locations and let the
subsequent vector-setting code do its work afterward, rather than just
commenting them out.


I'm still not seeing anything that convinces me that this change is
correct, or even more correct (using the metric of "number of
platforms broken") than what was there before.


cgd


  reply	other threads:[~2002-04-19 19:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-18 12:46 Alexandre Oliva
2002-04-18 13:44 ` Andrew Cagney
2002-04-19 14:00   ` Alexandre Oliva
     [not found] ` <mailpost.1019159224.1687@news-sj1-1>
2002-04-18 15:43   ` cgd
     [not found]     ` <1019238909.1702.35.camel@ghostwheel.cygnus.com>
     [not found]       ` <yov54ri7pnbe.fsf@broadcom.com>
2002-04-19 11:36         ` Eric Christopher
2002-04-19 12:06           ` cgd [this message]
2002-04-19 12:48             ` Eric Christopher
2002-04-19 14:07     ` Alexandre Oliva
2002-04-19 15:32       ` cgd
2002-04-22 12:09         ` Alexandre Oliva
2002-04-22 12:30           ` cgd
2002-04-23 18:24             ` Alexandre Oliva
     [not found]               ` <mailpost.1019611460.15770@news-sj1-1>
2002-04-24 11:19                 ` cgd
2002-04-20  9:43 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yov5y9fjo6dd.fsf@broadcom.com \
    --to=cgd@broadcom.com \
    --cc=aoliva@redhat.com \
    --cc=echristo@redhat.com \
    --cc=fche@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox