From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18199 invoked by alias); 19 Apr 2002 19:06:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18135 invoked from network); 19 Apr 2002 19:06:41 -0000 Received: from unknown (HELO mms3.broadcom.com) (63.70.210.38) by sources.redhat.com with SMTP; 19 Apr 2002 19:06:41 -0000 Received: from 63.70.210.1 by mms3.broadcom.com with ESMTP (Broadcom MMS-3 SMTP Relay (MMS v4.7)); Fri, 19 Apr 2002 12:06:37 -0700 X-Server-Uuid: 1e1caf3a-b686-11d4-a6a3-00508bfc9ae5 Received: from dt-sj3-118.sj.broadcom.com (dt-sj3-118 [10.21.64.118]) by mail-sj1-5.sj.broadcom.com (8.12.2/8.12.2) with ESMTP id g3JJ6e1S004390; Fri, 19 Apr 2002 12:06:40 -0700 (PDT) Received: (from cgd@localhost) by dt-sj3-118.sj.broadcom.com ( 8.9.1/SJ8.9.1) id MAA13814; Fri, 19 Apr 2002 12:06:39 -0700 (PDT) To: "Eric Christopher" cc: aoliva@redhat.com, fche@redhat.com, gdb-patches@sources.redhat.com Subject: Re: MIPS simulator initializes LSI pmon vector table with code References: <1019238909.1702.35.camel@ghostwheel.cygnus.com> <1019241298.12982.2.camel@ghostwheel.cygnus.com> From: cgd@broadcom.com Date: Fri, 19 Apr 2002 12:06:00 -0000 In-Reply-To: "Eric Christopher"'s message of "19 Apr 2002 11:34:58 -0700" Message-ID: MIME-Version: 1.0 X-WSS-ID: 10DEB537876-01-01 Content-Type: text/plain Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00633.txt.bz2 At 19 Apr 2002 11:34:58 -0700, Eric Christopher wrote: > This was support that worked a while back and the change that Alex is > reverting broke the LSI support. We aren't supporting something new, > we're fixing something that someone else broke :) well, at some point in time perhaps. it looks like this code has been in the public cvs tree in some form forever. rev 1.1 did code like this, but it was moved in rev 1.2 (by fche) to later in the function and made conditional on perhaps the wrong variables. "change that Alex is reverting" isn't a good description: if he actually had reverted the change that put those there, he would have put those calls back in their original locations and let the subsequent vector-setting code do its work afterward, rather than just commenting them out. I'm still not seeing anything that convinces me that this change is correct, or even more correct (using the metric of "number of platforms broken") than what was there before. cgd