Re: MIPS simulator initializes LSI pmon vector table with code

[Eric Christopher <echristo@redhat.com>]

On Fri, 2002-04-19 at 12:06, cgd@broadcom.com wrote:
> At 19 Apr 2002 11:34:58 -0700, Eric Christopher wrote:
> > This was support that worked a while back and the change that Alex is
> > reverting broke the LSI support. We aren't supporting something new,
> > we're fixing something that someone else broke :)
> 
> well, at some point in time perhaps.
> 
> it looks like this code has been in the public cvs tree in some form
> forever.
> 

Forever is a very long time. mips16 didn't work in net gcc for more than
a year and a half until somebody (me) noticed :)

> rev 1.1 did code like this, but it was moved in rev 1.2 (by fche) to
> later in the function and made conditional on perhaps the wrong
> variables.
> 

OK.

> 
> "change that Alex is reverting" isn't a good description: if he
> actually had reverted the change that put those there, he would have
> put those calls back in their original locations and let the
> subsequent vector-setting code do its work afterward, rather than just
> commenting them out.
> 

True.

> 
> I'm still not seeing anything that convinces me that this change is
> correct, or even more correct (using the metric of "number of
> platforms broken") than what was there before.
> 

OK. I'll let Alex explain the sequence of events that shows that the
current code isn't correct, or at least breaks what used to be the
"existing" lsi support :)

-eric

-- 
Written using state-of-the-rat
technology.