Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: cgd@broadcom.com
To: aoliva@redhat.com
Cc: gdb-patches@sources.redhat.com, fche@redhat.com, echristo@redhat.com
Subject: Re: MIPS simulator initializes LSI pmon vector table with code
Date: Thu, 18 Apr 2002 15:43:00 -0000	[thread overview]
Message-ID: <yov5vgaor5ky.fsf@broadcom.com> (raw)
In-Reply-To: aoliva@redhat.com's message of "Thu, 18 Apr 2002 19:47:04 +0000 (UTC)"

At Thu, 18 Apr 2002 19:47:04 +0000 (UTC), "Alexandre Oliva" wrote:
> There's a chunk of memory in LSI pmon that is supposed to contain
> pointers to `system call' handlers.

What Andrew said, and...

Actually, your patch seems incorrect.

The code at 0xbfc00200, etc., _ARE_ supposed to be code; in MIPS
they're various exception entry points.  If they are data which is
invalid code, the wrong thing will almost certainly happen.

I cannot believe that any monitor does what you describe (puts a table
of addresses here), as doing so (instead of putting vectors there)
would be fundamentally incompatible with the MIPS architecture.


> However, sim_open() will
> clobber the valid addresses it stores in this table with code bare
> code (as opposed to pointers to code) that was meant to catch invalid
> accesses.  This is obviously wrong.  I'm checking this in, since Frank
> Ch. Eigler and Eric Christopher agreed it was a reasonable thing to
> do.  I'll leave the complete fix for someone who has a real
> understanding of what was supposed to be done there.

Please justify this further, preferably with a pointer to
code that is broken by the old behaviour or to documentation.

Otherwise, I think this should almost certainly be backed out...



cgd


  parent reply	other threads:[~2002-04-18 22:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-18 12:46 Alexandre Oliva
2002-04-18 13:44 ` Andrew Cagney
2002-04-19 14:00   ` Alexandre Oliva
     [not found] ` <mailpost.1019159224.1687@news-sj1-1>
2002-04-18 15:43   ` cgd [this message]
     [not found]     ` <1019238909.1702.35.camel@ghostwheel.cygnus.com>
     [not found]       ` <yov54ri7pnbe.fsf@broadcom.com>
2002-04-19 11:36         ` Eric Christopher
2002-04-19 12:06           ` cgd
2002-04-19 12:48             ` Eric Christopher
2002-04-19 14:07     ` Alexandre Oliva
2002-04-19 15:32       ` cgd
2002-04-22 12:09         ` Alexandre Oliva
2002-04-22 12:30           ` cgd
2002-04-23 18:24             ` Alexandre Oliva
     [not found]               ` <mailpost.1019611460.15770@news-sj1-1>
2002-04-24 11:19                 ` cgd
2002-04-20  9:43 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yov5vgaor5ky.fsf@broadcom.com \
    --to=cgd@broadcom.com \
    --cc=aoliva@redhat.com \
    --cc=echristo@redhat.com \
    --cc=fche@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox