From: DJ Delorie <dj@redhat.com>
To: Ed Schouten <ed@nuxi.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty
Date: Sun, 29 May 2016 16:32:00 -0000 [thread overview]
Message-ID: <xnh9dg3jw0.fsf@greed.delorie.com> (raw)
In-Reply-To: <CABh_MKn1yUfKjtZO4nZ+XyvVXHUgtD7QE-hAM-AP6FNH=zKooQ@mail.gmail.com> (message from Ed Schouten on Sun, 29 May 2016 16:58:28 +0200)
Ed Schouten <ed@nuxi.nl> writes:
> For now I'm solving this by simply patching up libiberty to pull in
> the declaration from libgen.h. This seems to make everything build
> again.
Unless you check *every* one of those operating systems, and put in a
configure test for libgen and test for it, this patch is wrong.
Most likely, you're not calling configure right, else it would have seen
the right prototype and skipped this part of the header. Or libiberty's
configure and tests need to check for libgen.h as well as the other
headers it's checking for.
Either way, you can't blindly depend on a header being present and
useful. "Seems to" is insufficient evidence that a patch is correct.
next prev parent reply other threads:[~2016-05-29 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 14:58 Ed Schouten
2016-05-29 16:32 ` DJ Delorie [this message]
2016-05-29 16:36 ` Ed Schouten
2016-05-29 17:06 ` DJ Delorie
2016-05-29 17:24 ` Ed Schouten
2016-05-29 17:35 ` DJ Delorie
2016-06-02 21:27 ` Joseph Myers
2016-06-03 9:37 ` Ed Schouten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xnh9dg3jw0.fsf@greed.delorie.com \
--to=dj@redhat.com \
--cc=ed@nuxi.nl \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox