Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty

[Ed Schouten <ed@nuxi.nl>]

Hi there,

2016-05-29 18:32 GMT+02:00 DJ Delorie <dj@redhat.com>:
> Most likely, you're not calling configure right, else it would have seen
> the right prototype and skipped this part of the header.  Or libiberty's
> configure and tests need to check for libgen.h as well as the other
> headers it's checking for.

Exactly. ./configure does not check for the existence of libgen.h, nor
does it try to include it anywhere in its codebase.

> Either way, you can't blindly depend on a header being present and
> useful.  "Seems to" is insufficient evidence that a patch is correct.

For the local change I'm going to make to the FreeBSD base system and
ports collection, this works for me. I'm merely forwarding the patch
that I'm currently using.

That said, we can easily validate whether <libgen.h> is always
present. What's the official list on which GDB is supposed to build?
It's merely a matter of going down that list and looking at
documentation/source files.

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717