From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62239 invoked by alias); 29 May 2016 16:36:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62229 invoked by uid 89); 29 May 2016 16:36:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=U*dj, dj@redhat.com, djredhatcom, existence X-HELO: mail-yw0-f177.google.com Received: from mail-yw0-f177.google.com (HELO mail-yw0-f177.google.com) (209.85.161.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 29 May 2016 16:36:08 +0000 Received: by mail-yw0-f177.google.com with SMTP id c127so145737112ywb.1 for ; Sun, 29 May 2016 09:36:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=HToDQcvtcmCGmQVBdH8ojSgNJskXQEGZPcMITDKpkrI=; b=G5/z0Jf9Bz0Id1vWDnR0HkeHSlrE7coUOna3a9Ce1tistdoiXI3kzcjgcl59TfcL0G xjw4d+Rg/idMDEKp+yBbJhI7iGBLpfRL6AfGNurlvIKv+lubbFyZGDnRNn8ei47KLm82 sMptl95SkajTXA9BpPTV5O9XJV8zLDCKV+TMmC5jF32SiJt2DrSrIhKzCokEn7czbJ3r v7+zeQPe84qO+Vebj0ZYZrAqPpKNWnB6zhSdlndd55CSt4kn8Spu1A27O3Ys0JQO5NEw KKowBzRE7IDLnAgfFI4ASyBI7VpUT/GqJeYvTZvckYyK09upqY0R9QDluQhxtlP+f9IH vYHw== X-Gm-Message-State: ALyK8tKozdJEhBsuSfbI4EzoyiKMMNHANcdgZMujAZ77tibkkWqJd8XdPaAMKGSlY9D9C30LDr/BUDdBKjag4A== MIME-Version: 1.0 X-Received: by 10.13.198.5 with SMTP id i5mr15721051ywd.263.1464539766042; Sun, 29 May 2016 09:36:06 -0700 (PDT) Received: by 10.13.201.199 with HTTP; Sun, 29 May 2016 09:36:05 -0700 (PDT) In-Reply-To: References: Date: Sun, 29 May 2016 16:36:00 -0000 Message-ID: Subject: Re: Likely incorrect patch: remove the faulty basename() prototype from libiberty From: Ed Schouten To: DJ Delorie Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-05/txt/msg00524.txt.bz2 Hi there, 2016-05-29 18:32 GMT+02:00 DJ Delorie : > Most likely, you're not calling configure right, else it would have seen > the right prototype and skipped this part of the header. Or libiberty's > configure and tests need to check for libgen.h as well as the other > headers it's checking for. Exactly. ./configure does not check for the existence of libgen.h, nor does it try to include it anywhere in its codebase. > Either way, you can't blindly depend on a header being present and > useful. "Seems to" is insufficient evidence that a patch is correct. For the local change I'm going to make to the FreeBSD base system and ports collection, this works for me. I'm merely forwarding the patch that I'm currently using. That said, we can easily validate whether is always present. What's the official list on which GDB is supposed to build? It's merely a matter of going down that list and looking at documentation/source files. -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717